Conversation
* origin/tomas/fix-max-wait-tries: changelog: #1456 client: stop waiting for catch-up when max tries are reached
* origin/tomas/find-validator-by-tm: changelog: add #1344 pos: add a query to find validator by Tendermint address
* cwgoes/cse-in-inflation: Common sub-expression elimination in inflation calculation
* adrian/upgrade_cometbft: use cometbft binary
* cwgoes/remove-unused-named-address: update changelog Remove unused module
10 tasks
added 5 commits
June 8, 2023 07:25
…n_id reading from submit functions.
adrianbrink
reviewed
Jul 3, 2023
| tx_epoch.unwrap() != submission_epoch => | ||
| { | ||
| // Then we probably straddled an epoch boundary. Let's retry... | ||
| eprintln!( |
Contributor
There was a problem hiding this comment.
we can merge this but all these eprintln statements make this hard to use, similar to panics because consumers can't catch the errors to display useful error messages to users.
adrianbrink
previously approved these changes
Jul 3, 2023
Contributor
adrianbrink
left a comment
adrianbrink
left a comment
There was a problem hiding this comment.
I'm okay with these changes
jurevans
previously approved these changes
Jul 3, 2023
jurevans
left a comment
jurevans
left a comment
There was a problem hiding this comment.
This looks good to me! For reference, here is how we are utilizing these changes:
murisi
force-pushed
the
murisi/separate-signing
branch
from
25cc553 to
8224f75
Compare
This was referenced Jul 4, 2023
Closed
Closed
Closed
brentstone
added a commit
that referenced
this pull request
Jul 5, 2023
* murisi/separate-signing: Added changelog entry. Factored out the submission of the reveal PK transaction. Simplified the reveal PK transaction construction flow. Factored chain_id reading from submit functions. Allow Tx builders to take verification keys. Increased usage of PublicKeys relative to SecretKeys in tx construction. Only reveal a public key when the signer is an implicit address. Now only use TxBroadcastData::Wrapper for non dry runs. Now update proof of work solution in transaction header. Separating out the reveal PK transaction construction. Separate transaction building from signing from submission. Removed unnecessary header updates for dry runs. fixup! Merge 'origin/fraccaman/fix-sdk-tx-with-hash' (#1474) sdk: use hash instead of wasm code Revert "Merge 'origin/fraccaman/fix-sdk-tx-with-hash' (#1474)" Revert "fixup! Merge 'origin/fraccaman/fix-sdk-tx-with-hash' (#1474)" fixup!: don't call `process_slashes` within `advance_epoch` clean up logging fix clippy remove test code until slash pool transfers are solved rip slash pool fixup! Merge 'origin/fraccaman/fix-sdk-tx-with-hash' (#1474) get_slashed_amount: inclusive on infraction epoch add cli to sdk impl for tx unjail sdk: use hash instead of wasm code make find_slashes_in_ranges inclusive on end epoch withdraw: fix bounds for collecting slashes for an unbond aesthetic cleaning Update WASM checksums. revert bound cleaning for readability refactor slash lookup fixup! add cubic_slash_window_length to bounds (maybe still needs change) update changelog Remove unused module Fixed local tx prover dependency regression. use cometbft binary Fixed the header of transactions in dry_run. Updated the WASM checksums. remove unused cubic slash function changelog: add #1444 fixup! store total bond sums of each validator for efficient computation refactor epoch offsets with params methods store total bond sums of each validator for efficient computation pos/lib.rs: WIP fix things inside of `bonds_and_unbonds` fix PoS client query related functions fix `bond_amount` pos: cubic slashing with new procedure for recording and unbonding/withdrawing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently transaction building, signing, and submission are all combined into single functions in the SDK. This setup makes it hard for web clients using the SDK to elect to use a hardware wallet to sign transactions instead. So this PR separates the transaction building operation from the signing and the submission operations in the SDK.