Merged
Conversation
murisi
force-pushed
the
murisi/fix-dry-run-header-and-prover
branch
from
0764bcc to
e00ce23
Compare
mateuszjasiuk
approved these changes
Jun 9, 2023
Contributor
mateuszjasiuk
left a comment
mateuszjasiuk
left a comment
There was a problem hiding this comment.
Tested web interface targeting this and it works well!
LGTM!
Collaborator
|
ill merge this to draft, thanks! |
tzemanovic
approved these changes
Jun 9, 2023
Closed
Fraccaman
added a commit
that referenced
this pull request
Jun 12, 2023
* origin/murisi/fix-dry-run-header-and-prover: Added a changelog entry for this fix. Fixed the header of transactions in dry_run. Fixed local tx prover dependency regression.
Fraccaman
added a commit
that referenced
this pull request
Jun 14, 2023
* origin/murisi/fix-dry-run-header-and-prover: Added a changelog entry for this fix. Fixed the header of transactions in dry_run. Fixed local tx prover dependency regression.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed an issue preventing the Namada SDK from being used from the web client. More precisely, the SDK now uses the
LocalTxProversupplied fromShieldedUtils. Also removed a usage of theDecryptedTxheader fromapps/src/lib/client/tx.rs, now preferring to install it insidedry_run_tx(as was done in the past).