Conversation
batconjurer
approved these changes
Jul 28, 2023
juped
added a commit
that referenced
this pull request
Aug 9, 2023
…nto main * namada/brent/fix-dec-display: changelog: #1774 fix Display for Dec
Fraccaman
added a commit
that referenced
this pull request
Aug 11, 2023
* origin/brent/fix-dec-display: changelog: #1774 fix Display for Dec
Closed
Fraccaman
added a commit
that referenced
this pull request
Aug 11, 2023
* origin/tomas/rm-dead-file: rm accidentally revived file replaced by `apps/src/lib/cli/client.rs` changelog: #1774 fix Display for Dec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
The
Displaytrait forDecis buggy such that if I have a number14000.000, the number is displayed as14. We attempt to strip the zeros to the right of the.and the.itself, but we end up stripping all the zeros left-adjacent to the.as well. The stripping is fixed now.Indicate on which release or other PRs this topic is based on
v0.20.1
Checklist before merging to
draft