Nondegenerate multisignature hardware wallets#1884
Merged
brentstone merged 4 commits intomainfrom Sep 25, 2023
Merged
Conversation
murisi
changed the title
murisi
changed the title
murisi
force-pushed
the
murisi/multisig-fixes
branch
from
c1aafa9 to
3c7bdba
Compare
Fraccaman
previously approved these changes
Sep 13, 2023
grarco
reviewed
Sep 13, 2023
| let amt_verified = usize::from(amt_verifieds.is_err()) | ||
| + verified_pks.len() | ||
| - prev_verifieds; | ||
| x.consume(VERIFY_TX_SIG_GAS_COST * amt_verified as u64) |
Collaborator
There was a problem hiding this comment.
I think that given this rework it would be slightly better to move the gas accounting part directly into the verify_signature method of Signature, to have a highest possible resolution. But we can do this later
grarco
previously approved these changes
Sep 13, 2023
Collaborator
grarco
left a comment
grarco
left a comment
There was a problem hiding this comment.
Looks good to me, thanks!
1 task
murisi
force-pushed
the
murisi/multisig-fixes
branch
from
998fd82 to
6eff4a9
Compare
Closed
murisi
added a commit
that referenced
this pull request
Sep 20, 2023
Fraccaman
added a commit
that referenced
this pull request
Sep 25, 2023
* origin/murisi/multisig-fixes: Added changelog entry. Added support for compressed signatures coming from hardware wallets. Combining Signature and MultiSignature sections to deduplicate hardware wallet code. Allow public key to be specified in signature section.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
namada-interface(we should explore in future whether this can be used to reduce size of signature sections on protocol)Indicate on which release or other PRs this topic is based on
Namada v0.22.0
Checklist before merging to
draft