Merged
Conversation
sug0
force-pushed
the
tiago/int-test-services
branch
from
4687c1c to
da706ad
Compare
Collaborator
Author
|
Successful CI run with the services enabled: 481fc72 |
This enables processing Ethereum events, broadcasting protocol transactions, among other things, while running integration tests.
sug0
force-pushed
the
tiago/int-test-services
branch
from
481fc72 to
227028a
Compare
batconjurer
requested changes
Oct 16, 2023
Collaborator
batconjurer
left a comment
batconjurer
left a comment
There was a problem hiding this comment.
Code wise, one nit. Do we know this infra will work with ethereum tests though?
Collaborator
Author
|
@batconjurer I think these changes encompass all the requirements to simulate an ethereum node running, as well as protocol txs generated from the observed ethereum events. if not... well, I can always refactor the code a bit in the PR that actually adds the eth bridge integration tests |
batconjurer
previously approved these changes
Oct 16, 2023
sug0
force-pushed
the
tiago/int-test-services
branch
from
227028a to
9c69e4b
Compare
Closed
Fraccaman
added a commit
that referenced
this pull request
Oct 18, 2023
* origin/tiago/int-test-services: Changelog for #1976 Improve reading flow of mock node service defs Mock ledger services in integration tests
Fraccaman
added a commit
that referenced
this pull request
Oct 23, 2023
* origin/tiago/int-test-services: Changelog for #1976 Improve reading flow of mock node service defs Mock ledger services in integration tests
tzemanovic
added a commit
that referenced
this pull request
Oct 24, 2023
* origin/tiago/int-test-services: Changelog for #1976 Improve reading flow of mock node service defs Mock ledger services in integration tests
Merged
tzemanovic
approved these changes
Oct 24, 2023
brentstone
pushed a commit
that referenced
this pull request
Nov 11, 2023
* origin/tiago/int-test-services: Changelog for #1976 Improve reading flow of mock node service defs Mock ledger services in integration tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Indicate on which release or other PRs this topic is based on
Based on #1964
Checklist before merging to
draft