Conversation
sug0
force-pushed
the
tiago/sign-eth-txs
branch
from
603ce88 to
8bec66e
Compare
Fraccaman
approved these changes
Oct 20, 2023
Closed
29 tasks
|
Not easy, Difficult installation |
Fraccaman
added a commit
that referenced
this pull request
Oct 23, 2023
* origin/tiago/sign-eth-txs: Changelog for #2012 Query chain id to be used in the eth wallet Require relayer to specify eth key Fetch Ethereum relayer key from env
tzemanovic
added a commit
that referenced
this pull request
Oct 24, 2023
* origin/tiago/sign-eth-txs: Changelog for #2012 Query chain id to be used in the eth wallet Require relayer to specify eth key Fetch Ethereum relayer key from env
Merged
brentstone
pushed a commit
that referenced
this pull request
Nov 11, 2023
* origin/tiago/sign-eth-txs: Changelog for #2012 Query chain id to be used in the eth wallet Require relayer to specify eth key Fetch Ethereum relayer key from env
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Introduce an environment variable to load a secp256k1 private key from, which is used to sign transactions originating from Namada's relayer sent to Ethereum.
This implementation is kinda hacky, but it should allow immediate testing with e.g. Sepolia. There are for sure ways to improve it, in the future, namely:
namadaw,ledger, oraws kms)ethereum-addressSDK/CLI argument from aSignerimplementation (see this link)Notice that the SDK code remains unchanged. This is because it accepts a
Middlewareclient, which may or may not sign txs.Indicate on which release or other PRs this topic is based on
v0.23.0Checklist before merging to
draft