Merged
Conversation
yito88
previously approved these changes
Oct 24, 2023
tzemanovic
previously approved these changes
Oct 26, 2023
This was referenced Oct 26, 2023
Closed
sug0
force-pushed
the
tiago/ibc-token-addr
branch
from
d009715 to
8456601
Compare
Closed
sug0
added a commit
that referenced
this pull request
Nov 8, 2023
yito88
approved these changes
Nov 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Precursor to #2018
This PR swaps IBC token hashes stored in the
Addresstype asStringvalues with newIbcTokenHashvalues, which internally are represented by an array of 20 bytes.Indicate on which release or other PRs this topic is based on
v0.25.0Checklist before merging to
draft