Merged
Conversation
This was referenced Nov 17, 2023
Closed
Closed
batconjurer
force-pushed
the
tiago/remove-genesis-aliases
branch
from
5b42e36 to
62572be
Compare
sug0
force-pushed
the
tiago/remove-genesis-aliases
branch
from
9ef1ad5 to
ea6f629
Compare
Additionally, lazy-load the pre-genesis user and validator wallets, such that loading a key during a test does not result in a new I/O operation.
This reverts commit 284b2a0.
tzemanovic
force-pushed
the
tiago/remove-genesis-aliases
branch
from
25138f1 to
c7e2b42
Compare
Collaborator
tzemanovic
approved these changes
Dec 6, 2023
2 tasks
tzemanovic
added a commit
that referenced
this pull request
Dec 7, 2023
* tiago/remove-genesis-aliases: changelog: add #2186 small grammar fixes benches: fix the default validator key for signing txs genesis: update starter README genesis: update README and update files Mandatory `--pre-genesis` flag Pre-genesis wallet fixes Tune error message on invalid chain id Make pre-genesis a global arg Add some lobsters or something Revert "Fix bug in cli arg multi" Fix bug in cli arg multi Fix e2e test setup Change aliases arg Check if two pubkeys are used for the same established acc Improve genesis tx signing's janky code Output unsigned established account txs struct Fix signatures once again Denominate amounts before signing them Fix localnet template sigs Set new pre-genesis txs timestamp Genesis bond subcmd Revert "Use a Unix epoch as a pre-genesis tx timestamp" Use a Unix epoch as a pre-genesis tx timestamp Fix typo Convert some static strs to consts Make `vp_user` a constant Update masp proofs gen_localnet working on mac os End-to-end test fixes add other missing e2e tests to CI fix `test_bond_queries` and trigger in CI Fix e2e wallet tests Temporarily disable test_bond_queries fixing more dumb shit Appease clippy Set chain id in e2e tests through env var Allow the chain id to be configured through an env var Fixed stupid epoch sleep and now pass chain-id to post-genesis ledger commands [fix] Wallet can generated keys without genesis files more e2e fixes [fix]: fix e2e test Fix setup process on e2e tests Rename sign genesis txs subcmd Generate localnet script fixes Improve signing failure error msg Update masp proofs Add base dir arg to gen localnet script Fix dev genesis wip: fixing localnet genesis templates lifetime heaven lifetime hell Validator key validation Sign over an actual become validator tx Implement signable tx helper Sign over an actual bond tx sumbish Temporarily revert hw wallet signing changes some dicking around [feat]: Fixed cli tooling for multi-signing txs Revert "Unify genesis templates" Unify genesis templates Revert "Remove established account init CLI subcmd" clippy is pleased wip mess Implement serde serialization for validator meta Implement Display and FromStr for established addrs Fix rebase + multisig related compilation issues Remove established account init CLI subcmd rebased on v0.27 and some initial multisig fixes Fix masp integration tests Update masp proofs CLI utils subcmd to derive genesis account addrs Rework CLI utils subcmd to generate validator account genesis tx CLI utils subcmd to generate established account genesis tx Fix PoS rewards rounding errors in unit tests Adjust dev genesis Early check of available balance to bond Fix localnet genesis templates Load test established addrs from pre-genesis wallet Remove aliases from genesis templates
tzemanovic
added a commit
that referenced
this pull request
Dec 7, 2023
tzemanovic
added a commit
that referenced
this pull request
Dec 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
(before rebase: b0a1fe3)
Indicate on which release or other PRs this topic is based on
Based on #2208
Checklist before merging to
draft