Merged
Conversation
Collaborator
Author
|
Note: the integration tests are actually passing for me locally, they fail here because of a time limit on the CI step |
murisi
approved these changes
Dec 1, 2023
Collaborator
murisi
left a comment
murisi
left a comment
There was a problem hiding this comment.
Looks good to me, thanks! Can I assume that the integration tests don't take significantly more time to execute on your machine than before your changes?
| // Test that a masp unshield transaction can be succesfully executed even across | ||
| // an epoch boundary. | ||
| #[test] | ||
| fn cross_epoch_tx() -> Result<()> { |
Collaborator
There was a problem hiding this comment.
Can I assume that assume that CI integration test failure is due solely to the additional time taken by this test?
Collaborator
Author
There was a problem hiding this comment.
Yes I can confirm, all the masp integration tests pass locally, seems to be just due to the timeout on the CI step
Closed
Closed
tzemanovic
added a commit
that referenced
this pull request
Dec 8, 2023
* origin/grarco/masp-cross-epoch-proof-fix: Changelog #2222 Updates masp fixtures for tests Refactors `convert_amount` Tests masp cross-epoch unshield Allows unshielding assets from previous epochs
tzemanovic
added a commit
that referenced
this pull request
Dec 8, 2023
brentstone
added a commit
that referenced
this pull request
Dec 29, 2023
* origin/grarco/masp-cross-epoch-proof-fix: Changelog #2222 Updates masp fixtures for tests Refactors `convert_amount` Tests masp cross-epoch unshield Allows unshielding assets from previous epochs
brentstone
added a commit
that referenced
this pull request
Dec 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Addresses #2094.
Closes #307 (@murisi not completely sure about this).
Closes #1880.
Allows to unshield assets from the MASP that belong to older epochs.
Indicate on which release or other PRs this topic is based on
v0.27.0
Checklist before merging to
draft