Merged
Conversation
Contributor
Author
All are fixed. |
karbyshev
force-pushed
the
aleks/wallet-cli-revamping-main-rebased
branch
2 times, most recently
from
d4e9df5 to
8fe26ee
Compare
karbyshev
force-pushed
the
aleks/wallet-cli-revamping-main-rebased
branch
from
8fe26ee to
26ca60c
Compare
Collaborator
|
great work @karbyshev! Do you think this PR is ready? |
Contributor
Author
|
@Fraccaman Thanks! I think it can be merged, but additional testing could be helpful. |
Closed
Fraccaman
pushed a commit
that referenced
this pull request
Dec 27, 2023
* origin/aleks/wallet-cli-revamping-main-rebased: Add changelog Remove unused import Fix messages Adapt e2e tests to new wallet cli Improve decryption status line Improve output if keypair could not be decypted Fix export / import Minor Fix key import Implement `remove` command Expose store remove_alias functionality Allow to add public keys Refactoring Fix `find` command; refactoring Fix key / address listing Adapt e2e tests for new wallet cli Fix help message Improve comment Refactor parsing of `add` command value Improve message Merge find-key and find-addr Reverse find alias for payment address Store known payment addresses in bimap Improve help messages Fix typo Merge key and address list Fix comments and help messages Import key from file Implement raw key add; simplify cli for add command Improve some messages, comments Implement export for MASP spending keys Update help messages for `gen` and `derive` Fix output message Add todo Fix: normalize alias strings Make `--alias` obligatory for gen / derive Refactoring Rename structures Restore raw key generation functionality Refactor payment key gen Unify cli for key export / add Refactor key export Unify cli for transparent / shielded key / address listing / searching Unify cli for transparent / shielded key listing Unify cli for secret / spending key derivation Unify cli for secret / spending key generation
brentstone
added a commit
that referenced
this pull request
Dec 29, 2023
* origin/aleks/wallet-cli-revamping-main-rebased: Add changelog Remove unused import Fix messages Adapt e2e tests to new wallet cli Improve decryption status line Improve output if keypair could not be decypted Fix export / import Minor Fix key import Implement `remove` command Expose store remove_alias functionality Allow to add public keys Refactoring Fix `find` command; refactoring Fix key / address listing Adapt e2e tests for new wallet cli Fix help message Improve comment Refactor parsing of `add` command value Improve message Merge find-key and find-addr Reverse find alias for payment address Store known payment addresses in bimap Improve help messages Fix typo Merge key and address list Fix comments and help messages Import key from file Implement raw key add; simplify cli for add command Improve some messages, comments Implement export for MASP spending keys Update help messages for `gen` and `derive` Fix output message Add todo Fix: normalize alias strings Make `--alias` obligatory for gen / derive Refactoring Rename structures Restore raw key generation functionality Refactor payment key gen Unify cli for key export / add Refactor key export Unify cli for transparent / shielded key / address listing / searching Unify cli for transparent / shielded key listing Unify cli for secret / spending key derivation Unify cli for secret / spending key generation
2 tasks
Contributor
Author
|
ZIP32 key derivation is implemented in #2417 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a revamped structure of the wallet CLI suggested in #2135. The changes are based on v0.28.0.
The following changes were additionally introduced.
--aliasargument is made obligatory forgen/derivecommands.--rawflag.Example:
namadaw gen --raw --alias key1exportfor MASP spending keysimportfor secret keys / MASP spending keysaddfor secret keysaddcommand. Example:namadaw add --alias my_entry --value val. The supported values:Future work:
Aliasstruct everywhere in order to force alias normalization?Checklist before merging to
draft