Merged
Conversation
4cc7e5c to
ea0a59b
Compare
tzemanovic
commented
Dec 14, 2023
ea0a59b to
306a634
Compare
tzemanovic
added a commit
that referenced
this pull request
Dec 14, 2023
627e66c to
54bba83
Compare
brentstone
pushed a commit
that referenced
this pull request
Dec 15, 2023
Closed
4484648 to
f167f2b
Compare
Co-authored-by: Tiago Carvalho <sugoiuguu@tfwno.gf>
* origin/main: ci: update mold ci: split integration and unit
brentstone
added a commit
that referenced
this pull request
Dec 19, 2023
* tomas/nicer-client-tx-result: Merge remote-tracking branch 'origin/main' refactor and use ProcessTxResponse::is_applied_and_valid core: add a note on transaction ResultCode Update sdk/src/tx.rs tests: add consts for ledger startup exp strings tests: replace expected tx failure string with a const tests: replace expected tx strings with consts changelog: add #2276 Rename ErrorCodes to ResultCode and make TxReponse.height typed sdk: use typed `ErrorCodes` for `TxResponse` move tx ErrorCodes type to core sdk: remove `initialized_accounts` from `TxResponse` (it's in inner_tx) tests: update expected tx result strings refactor tx response and result sdk/tx: remove unused `ProcessTxResponse` case
brentstone
added a commit
that referenced
this pull request
Dec 19, 2023
* tomas/nicer-client-tx-result: Merge remote-tracking branch 'origin/main' refactor and use ProcessTxResponse::is_applied_and_valid core: add a note on transaction ResultCode Update sdk/src/tx.rs tests: add consts for ledger startup exp strings tests: replace expected tx failure string with a const tests: replace expected tx strings with consts changelog: add #2276 Rename ErrorCodes to ResultCode and make TxReponse.height typed sdk: use typed `ErrorCodes` for `TxResponse` move tx ErrorCodes type to core sdk: remove `initialized_accounts` from `TxResponse` (it's in inner_tx) tests: update expected tx result strings refactor tx response and result sdk/tx: remove unused `ProcessTxResponse` case
brentstone
added a commit
that referenced
this pull request
Dec 29, 2023
* origin/tomas/nicer-client-tx-result: Merge remote-tracking branch 'origin/main' refactor and use ProcessTxResponse::is_applied_and_valid core: add a note on transaction ResultCode Update sdk/src/tx.rs tests: add consts for ledger startup exp strings tests: replace expected tx failure string with a const tests: replace expected tx strings with consts changelog: add #2276 Rename ErrorCodes to ResultCode and make TxReponse.height typed sdk: use typed `ErrorCodes` for `TxResponse` move tx ErrorCodes type to core sdk: remove `initialized_accounts` from `TxResponse` (it's in inner_tx) tests: update expected tx result strings refactor tx response and result sdk/tx: remove unused `ProcessTxResponse` case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
TxResultevent #20The
TxResponsetype is updated to contain a typedinner_tx: TxResultfor inner txs and some of its other fields are now typed. This is to make it possible to check a tx result in the client before taking further actions that depend on the result.Stdout from a transaction now looks like this:
A failed tx prints more info, e.g.:
Indicate on which release or other PRs this topic is based on
#2218 - diff range for review https://github.com/anoma/namada/pull/2276/files/dd28da14cefd6806ebfe71eb6a8ba8c894d975cd..f167f2b5b8396acf148fcc9cf992daf89f3b48a7
Checklist before merging to
draft