Skip to content

Governance queries improvements#2330

Merged
brentstone merged 8 commits intomainfrom
fraccaman+grarco/governance-tests
Jan 13, 2024
Merged

Governance queries improvements#2330
brentstone merged 8 commits intomainfrom
fraccaman+grarco/governance-tests

Conversation

@grarco
Copy link
Copy Markdown
Collaborator

@grarco grarco commented Dec 22, 2023

Describe your changes

  • Adds a new query_proposal_votes query
  • Improves the formatting of ProposalResult
  • Client does not submit a governance vote if the voter has no stake
  • Removes duplicated VoteType enum

Indicate on which release or other PRs this topic is based on

v0.29.0

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@grarco grarco force-pushed the fraccaman+grarco/governance-tests branch from a8793a7 to 63e6611 Compare January 2, 2024 10:59
@cwgoes cwgoes mentioned this pull request Jan 8, 2024
@grarco grarco changed the title Fraccaman+grarco/governance tests Governance queries improvements Jan 9, 2024
grarco added a commit that referenced this pull request Jan 9, 2024
@grarco grarco marked this pull request as ready for review January 9, 2024 11:16
@grarco grarco requested a review from Fraccaman January 9, 2024 11:16
@grarco grarco force-pushed the fraccaman+grarco/governance-tests branch from 0f0fe97 to cdb90df Compare January 9, 2024 12:06
brentstone added a commit that referenced this pull request Jan 10, 2024
* fraccaman+grarco/governance-tests:
  Changelog #2330
  Fixes broken governance test
  Removes duplicated proposal vote enum
  Removes useless `VoteType` enum. Misc refactors
  Returns early if proposal voter doesn't have a stake
  Improves governance messages
  Adds `query_proposal_votes`
  Improves formatting of `ProposalResult`
@brentstone brentstone merged commit e820bcc into main Jan 13, 2024
@brentstone brentstone deleted the fraccaman+grarco/governance-tests branch January 13, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants