Skip to content

move crates into crates dir#2386

Merged
tzemanovic merged 123 commits intomainfrom
tomas/crates-dir
Jan 17, 2024
Merged

move crates into crates dir#2386
tzemanovic merged 123 commits intomainfrom
tomas/crates-dir

Conversation

@tzemanovic
Copy link
Copy Markdown
Collaborator

@tzemanovic tzemanovic commented Jan 12, 2024 •
edited
Loading

Describe your changes

Moved most top-level crates into a crates subdir.

Indicate on which release or other PRs this topic is based on

#2312 - diff for review https://github.com/anoma/namada/pull/2386/files/21eddeaa1c6b181f7dead77f4bba0376dafc63c4..16a9f72f92de9d925abf42ffcf82d81ba279436c

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@tzemanovic
create trans_token crate from storage_api/token mod
dad7b63
@tzemanovic
trans_token: add storage_key and move relevant fns from core
d2e240e
@tzemanovic
move core token storage reads to trans_token::storage
0ee2f6d
@tzemanovic
core: replace token type import
b103c27
@tzemanovic
core: separate gov code into namada_governance crate
1520ad5
@tzemanovic
governance: update import paths
74843e1
@tzemanovic
core: move pgf into namada_governance
c39544a
@tzemanovic
gov: join pgf storage mods
5d0c3b1
@tzemanovic
add namada_ibc crate
c800630
@tzemanovic
core: make namada_shielded_token crate out of masp mods
4cd888a
@tzemanovic
shielded_token: move ConversionState into core::types::token
cc0b7ea
@tzemanovic
move some governance types back into core
31e8b84
@tzemanovic
core: move eth_bridge storage mods to ethereum_bridge crate
0562841
@tzemanovic
core: move merkle_tree into namada_merkle_tree crate
ee76120
@tzemanovic
core: add namada_storage crate out of ledger::storage
a469ad6
@tzemanovic
core: add namada_parameters crate out of ledger::parameters
566fa6d
@tzemanovic
parameters: fix imports
1e04b0f
@tzemanovic
core: move validate_tx_bytes into parameters crate
642a4e4
@tzemanovic
core: move ledger::gas into new namada_gas crate
3686e56
@tzemanovic
gas: fix imports
dbef2de
@tzemanovic
core: move proto and into namada_tx crate
94d1ba9
@tzemanovic
update lock
20de0b7
@tzemanovic
core: move types::transaction mods into namada_tx::data
a4490d4
@tzemanovic
core: make vp_env crate out of ledger::vp_env mod
5ef1d70
@tzemanovic
add namada_storage crate out of core::ledger::storage_api
6395320
@tzemanovic
add namada_tx_env out of core::ledger::tx_env mod
29a1704
@tzemanovic
tx_env: update imports
46fbd33
@tzemanovic
move core::types::internal::tx into namada_state::tx_queue
ff40cb5
@tzemanovic
add namada_account crate from namada_core::types::account
a77ccd0
@tzemanovic
namada_account: fix imports, update docstring
9882727
@tzemanovic tzemanovic marked this pull request as ready for review January 12, 2024 18:19
@tzemanovic tzemanovic requested a review from sug0 January 15, 2024 17:05
@tzemanovic tzemanovic mentioned this pull request Jan 15, 2024
Closed
sug0
sug0 previously approved these changes Jan 16, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@sug0 sug0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: core is still in the root of the project. we should remove it.
otherwise, lgtm

tzemanovic added a commit that referenced this pull request Jan 16, 2024
@tzemanovic
Merge branch 'tomas/crates-dir' (#2386)
c5f8ff0 
* origin/tomas/crates-dir:
  `mv crates/shared crates/namada` and update paths
  git: ignore the old proto artifact
  changelog: add #2386
  fix relative paths
  move most sub-crates into crates dir
@tzemanovic tzemanovic merged commit 9e7153d into main Jan 17, 2024
@tzemanovic tzemanovic deleted the tomas/crates-dir branch January 17, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sug0 sug0 sug0 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tzemanovic @sug0