Fix handling of the optional BIP39 passphrase flag#2489
Merged
tzemanovic merged 5 commits intomainfrom Feb 5, 2024
Merged
Conversation
tzemanovic
previously approved these changes
Jan 31, 2024
tzemanovic
approved these changes
Jan 31, 2024
Closed
Respect the optional bip39-passphrase flag for key derivation
brentstone
force-pushed
the
aleks/bip39-optional-derive
branch
from
0dccd02 to
07613e0
Compare
brentstone
added a commit
that referenced
this pull request
Feb 1, 2024
* aleks/bip39-optional-derive: Ignore clippy to-many-arguments Add changelog Fix punctuation Print alias for the existing key Fix bip39-passphrase flag handling in wallet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on v0.30.2