Disable Ethereum Bridge functionality at compile time#2602
Merged
tzemanovic merged 11 commits intomainfrom Apr 12, 2024
Merged
Conversation
e5fc9b8 to
888a29a
Compare
tzemanovic
reviewed
Feb 15, 2024
Collaborator
|
it would be good to add the feature to |
Collaborator
Author
I left it out of this PR on purpose. Figured we won't be enabling the Bridge any time soon, anyway. I can add it to the manifest files, though. |
batconjurer
reviewed
Feb 16, 2024
batconjurer
requested changes
Feb 16, 2024
Collaborator
batconjurer
left a comment
There was a problem hiding this comment.
I think we need to still run the unit tests with bridge enabled in the ci. Otherwise they won't be maintained and will rot and potentially be a big headache later.
888a29a to
129c8dd
Compare
129c8dd to
ff2b495
Compare
ff2b495 to
f88941e
Compare
f88941e to
7c9f10c
Compare
Collaborator
Author
|
added a CI task to run eth bridge tests |
7c9f10c to
8868e1c
Compare
8868e1c to
636ef54
Compare
636ef54 to
21f4c3d
Compare
98cbd8d to
b7cd34a
Compare
batconjurer
previously approved these changes
Feb 19, 2024
tzemanovic
previously approved these changes
Feb 22, 2024
2 tasks
b7cd34a to
c9d0a56
Compare
tzemanovic
added a commit
that referenced
this pull request
Apr 3, 2024
* origin/tiago/comptime-eth-bridge: Changelog for #2602 Enable Ethereum bridge testing in CI Include Makefile target to test Eth bridge Add `namada-eth-bridge` feature to Cargo manifests Stop benchmarking Ethereum bridge txs and vps Disable Namada Eth bridge CLI cmds Disable and/or adjust Bridge pool VP tests Disable Bridge pool txs Factor out Eth bridge activation status predicates Test comptime disabled Ethereum bridge Configure the status of the Eth bridge at comptime
tzemanovic
added a commit
that referenced
this pull request
Apr 3, 2024
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Closes #2598
Closes #2027
Indicate on which release or other PRs this topic is based on
v0.31.4Checklist before merging to
draft