Skip to content

fix: increase timeout from 30 to 180#2668

Merged
tzemanovic merged 3 commits intonamada-net:mainfrom
rllola:fix/time-out
Feb 22, 2024
Merged

fix: increase timeout from 30 to 180#2668
tzemanovic merged 3 commits intonamada-net:mainfrom
rllola:fix/time-out

Conversation

@rllola
Copy link
Copy Markdown
Contributor

@rllola rllola commented Feb 20, 2024

Describe your changes

Closes #2662

This change increase the timeout of the broadcaster from 30 to 180 seconds. In the last upgrade of the Shielded Expedition some validators couldn't restart their node because of the timeout. Increasing this value solved it and avoid restarting from scratch.

Indicate on which release or other PRs this topic is based on

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 20, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (c733be2) 53.38% compared to head (d593759) 53.37%.

Files Patch % Lines
crates/apps/src/lib/node/ledger/broadcaster.rs 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2668      +/-   ##
==========================================
- Coverage   53.38%   53.37%   -0.01%     
==========================================
  Files         302      302              
  Lines      103403   103407       +4     
==========================================
- Hits        55198    55194       -4     
- Misses      48205    48213       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Fraccaman Fraccaman requested review from sug0 and tzemanovic and removed request for tzemanovic February 20, 2024 11:14
@Fraccaman
Copy link
Copy Markdown
Collaborator

thanks @rllola! I've added some minor changes and fixed the changelog. Ill merge it next release!

Fraccaman pushed a commit that referenced this pull request Feb 20, 2024
* rllola/fix/time-out:
  added changelog
  added env var, minor refactor
  increase timeout from 30 to 180
@tzemanovic tzemanovic merged commit 5c73afb into namada-net:main Feb 22, 2024
@rllola rllola deleted the fix/time-out branch February 28, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Increase and make broadcaster timeout configurable

4 participants