fix: increase timeout from 30 to 180#2668
Merged
tzemanovic merged 3 commits intonamada-net:mainfrom Feb 22, 2024
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2668 +/- ##
==========================================
- Coverage 53.38% 53.37% -0.01%
==========================================
Files 302 302
Lines 103403 103407 +4
==========================================
- Hits 55198 55194 -4
- Misses 48205 48213 +8 ☔ View full report in Codecov by Sentry. |
8b8f6d1 to
d593759
Compare
sug0
approved these changes
Feb 20, 2024
Collaborator
|
thanks @rllola! I've added some minor changes and fixed the changelog. Ill merge it next release! |
Fraccaman
pushed a commit
that referenced
this pull request
Feb 20, 2024
* rllola/fix/time-out: added changelog added env var, minor refactor increase timeout from 30 to 180
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Closes #2662
This change increase the timeout of the broadcaster from 30 to 180 seconds. In the last upgrade of the Shielded Expedition some validators couldn't restart their node because of the timeout. Increasing this value solved it and avoid restarting from scratch.
Indicate on which release or other PRs this topic is based on
Checklist before merging to
draft