Fix default node param protocol for cli calls#2701
Merged
tzemanovic merged 3 commits intonamada-net:mainfrom Feb 27, 2024
Merged
Fix default node param protocol for cli calls#2701tzemanovic merged 3 commits intonamada-net:mainfrom
tzemanovic merged 3 commits intonamada-net:mainfrom
Conversation
Contributor
Author
|
cc @Fraccaman |
Collaborator
|
Ahhhhhh my bad, next release will include this! for now, have to always pass the |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2701 +/- ##
=======================================
Coverage 52.98% 52.99%
=======================================
Files 303 303
Lines 104166 104166
=======================================
+ Hits 55194 55202 +8
+ Misses 48972 48964 -8 ☔ View full report in Codecov by Sentry. |
tzemanovic
approved these changes
Feb 23, 2024
tzemanovic
added a commit
that referenced
this pull request
Feb 26, 2024
* fix-default-node: changelog: add #2701 test/e2e: use the default `--node` in a test fix default node param protocol for cli calls
brentstone
pushed a commit
that referenced
this pull request
Mar 4, 2024
* fix-default-node: changelog: add #2701 test/e2e: use the default `--node` in a test fix default node param protocol for cli calls
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Closes #2702
This fixes a bug introduced in #2658 which causes all cli requests to fail when no
--nodeparam is provided:Indicate on which release or other PRs this topic is based on
0.31.6
Checklist before merging to
draft