Skip to content

Fix default node param protocol for cli calls#2701

Merged
tzemanovic merged 3 commits intonamada-net:mainfrom
Krewedk0:fix-default-node
Feb 27, 2024
Merged

Fix default node param protocol for cli calls#2701
tzemanovic merged 3 commits intonamada-net:mainfrom
Krewedk0:fix-default-node

Conversation

@Krewedk0
Copy link
Copy Markdown
Contributor

@Krewedk0 Krewedk0 commented Feb 22, 2024

Describe your changes

Closes #2702

This fixes a bug introduced in #2658 which causes all cli requests to fail when no --node param is provided:

builder error for url (tcp://127.0.0.1:26657): URL scheme is not allowed

Indicate on which release or other PRs this topic is based on

0.31.6

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@Krewedk0
Copy link
Copy Markdown
Contributor Author

cc @Fraccaman

@Fraccaman
Copy link
Copy Markdown
Collaborator

Fraccaman commented Feb 22, 2024

Ahhhhhh my bad, next release will include this! for now, have to always pass the --node argument. Thanks for the PR!

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 52.99%. Comparing base (412accd) to head (3d3fa32).
Report is 2 commits behind head on main.

Files Patch % Lines
crates/apps/src/lib/cli/context.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2701   +/-   ##
=======================================
  Coverage   52.98%   52.99%           
=======================================
  Files         303      303           
  Lines      104166   104166           
=======================================
+ Hits        55194    55202    +8     
+ Misses      48972    48964    -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tzemanovic added a commit that referenced this pull request Feb 26, 2024
* fix-default-node:
  changelog: add #2701
  test/e2e: use the default `--node` in a test
  fix default node param protocol for cli calls
@tzemanovic tzemanovic merged commit 3a78df9 into namada-net:main Feb 27, 2024
brentstone pushed a commit that referenced this pull request Mar 4, 2024
* fix-default-node:
  changelog: add #2701
  test/e2e: use the default `--node` in a test
  fix default node param protocol for cli calls
@brentstone brentstone mentioned this pull request Mar 4, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TCP URL scheme is broken

3 participants