Merged
Conversation
4 tasks
brentstone
added a commit
that referenced
this pull request
Mar 8, 2024
brentstone
added a commit
that referenced
this pull request
Mar 8, 2024
brentstone
force-pushed
the
brent/limit-metadata-size
branch
from
5f6d12b to
76a1237
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2845 +/- ##
==========================================
- Coverage 53.88% 53.84% -0.05%
==========================================
Files 308 308
Lines 100154 100261 +107
==========================================
+ Hits 53967 53981 +14
- Misses 46187 46280 +93 ☔ View full report in Codecov by Sentry. |
brentstone
added a commit
that referenced
this pull request
Mar 8, 2024
brentstone
force-pushed
the
brent/limit-metadata-size
branch
from
76a1237 to
74dbeae
Compare
tzemanovic
previously approved these changes
Mar 8, 2024
sug0
reviewed
Mar 8, 2024
Collaborator
sug0
left a comment
sug0
left a comment
There was a problem hiding this comment.
we should also validate genesis metadata
(crates/apps/src/lib/config/genesis/transactions.rs)
brentstone
added a commit
that referenced
this pull request
Mar 8, 2024
brentstone
force-pushed
the
brent/limit-metadata-size
branch
from
74dbeae to
b961489
Compare
sug0
previously approved these changes
Mar 8, 2024
brentstone
added a commit
that referenced
this pull request
Mar 8, 2024
brentstone
force-pushed
the
brent/limit-metadata-size
branch
from
b961489 to
7e5c5a0
Compare
brentstone
added a commit
that referenced
this pull request
Mar 8, 2024
brentstone
force-pushed
the
brent/limit-metadata-size
branch
from
7e5c5a0 to
c978fdc
Compare
brentstone
added a commit
that referenced
this pull request
Mar 8, 2024
brentstone
force-pushed
the
brent/limit-metadata-size
branch
from
c978fdc to
c48a161
Compare
brentstone
force-pushed
the
brent/limit-metadata-size
branch
from
c48a161 to
39a62fc
Compare
tzemanovic
added a commit
that referenced
this pull request
Apr 1, 2024
* origin/brent/limit-metadata-size: fix bug for deleting metadata genesis metadata validation changelog: add #2845 refactor check metadata length in client check metadata length in VP
tzemanovic
added a commit
that referenced
this pull request
Apr 1, 2024
* brent/limit-metadata-size: wasm/vp_user: only read metadata if it's changed
tzemanovic
added a commit
that referenced
this pull request
Apr 10, 2024
* origin/brent/limit-metadata-size: wasm/vp_user: only read metadata if it's changed fix bug for deleting metadata genesis metadata validation changelog: add #2845 refactor check metadata length in client check metadata length in VP # Conflicts: # crates/sdk/src/tx.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Closes #2800.
Indicate on which release or other PRs this topic is based on
v0.31.9
Checklist before merging to
draft