Skip to content

Always use storage errors on native VPs#2852

Merged
tzemanovic merged 6 commits intomainfrom
tiago/vps-use-storage-err
Apr 12, 2024
Merged

Always use storage errors on native VPs#2852
tzemanovic merged 6 commits intomainfrom
tiago/vps-use-storage-err

Conversation

@sug0
Copy link
Copy Markdown
Collaborator

@sug0 sug0 commented Mar 8, 2024

Describe your changes

Replace eyre!() errors with namada_storage errors. This change will be useful in a future PR, to allow easily downcasting to the error contained in a boxed namada_storage result.

Indicate on which release or other PRs this topic is based on

v0.32.0

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

sug0 added a commit that referenced this pull request Mar 8, 2024
@sug0 sug0 requested review from batconjurer and tzemanovic March 8, 2024 12:55
@sug0 sug0 marked this pull request as ready for review March 8, 2024 12:56
sug0 added a commit that referenced this pull request Mar 8, 2024
@sug0 sug0 force-pushed the tiago/vps-use-storage-err branch from 792edbc to a31271e Compare March 8, 2024 13:15
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 53.44%. Comparing base (5e0b162) to head (18b2f75).
Report is 4 commits behind head on main.

Files Patch % Lines
...ledger/native_vp/ethereum_bridge/bridge_pool_vp.rs 55.17% 13 Missing ⚠️
crates/namada/src/ledger/native_vp/mod.rs 50.00% 10 Missing ⚠️
crates/ethereum_bridge/src/storage/parameters.rs 85.71% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2852   +/-   ##
=======================================
  Coverage   53.44%   53.44%           
=======================================
  Files         310      310           
  Lines      101574   101575    +1     
=======================================
+ Hits        54288    54289    +1     
  Misses      47286    47286           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sug0 sug0 force-pushed the tiago/vps-use-storage-err branch from a31271e to 18b2f75 Compare March 22, 2024 13:39
@sug0
Copy link
Copy Markdown
Collaborator Author

sug0 commented Mar 22, 2024

rebased on v0.32.0

tzemanovic added a commit that referenced this pull request Mar 26, 2024
* origin/tiago/wasm-errs-ux:
  Changelog for #2940
  Remove explicit out-of-gas checks during VP execution
  Rebuild wasms for tests
  Return a result of unit from VPs rather than of bools
  Extend bools and results with new helper methods
  Changelog for #2852
  Remove `eyre` from Ethereum Bridge Pool VP
  Remove `eyre` from NUT VP
  Remove `eyre` from Ethereum Bridge VP
  Remove `eyre` from Ethereum Bridge param errs
  Add a simple allocated storage err
tzemanovic added a commit that referenced this pull request Apr 1, 2024
* origin/tiago/vps-use-storage-err:
  Changelog for #2852
  Remove `eyre` from Ethereum Bridge Pool VP
  Remove `eyre` from NUT VP
  Remove `eyre` from Ethereum Bridge VP
  Remove `eyre` from Ethereum Bridge param errs
  Add a simple allocated storage err
tzemanovic added a commit that referenced this pull request Apr 10, 2024
* origin/tiago/vps-use-storage-err:
  Changelog for #2852
  Remove `eyre` from Ethereum Bridge Pool VP
  Remove `eyre` from NUT VP
  Remove `eyre` from Ethereum Bridge VP
  Remove `eyre` from Ethereum Bridge param errs
  Add a simple allocated storage err
@tzemanovic tzemanovic merged commit 2b32a55 into main Apr 12, 2024
@tzemanovic tzemanovic deleted the tiago/vps-use-storage-err branch April 12, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants