Always use storage errors on native VPs#2852
Merged
tzemanovic merged 6 commits intomainfrom Apr 12, 2024
Merged
Conversation
792edbc to
a31271e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2852 +/- ##
=======================================
Coverage 53.44% 53.44%
=======================================
Files 310 310
Lines 101574 101575 +1
=======================================
+ Hits 54288 54289 +1
Misses 47286 47286 ☔ View full report in Codecov by Sentry. |
tzemanovic
approved these changes
Mar 8, 2024
batconjurer
approved these changes
Mar 8, 2024
2 tasks
a31271e to
18b2f75
Compare
Collaborator
Author
|
rebased on |
tzemanovic
added a commit
that referenced
this pull request
Mar 26, 2024
* origin/tiago/wasm-errs-ux: Changelog for #2940 Remove explicit out-of-gas checks during VP execution Rebuild wasms for tests Return a result of unit from VPs rather than of bools Extend bools and results with new helper methods Changelog for #2852 Remove `eyre` from Ethereum Bridge Pool VP Remove `eyre` from NUT VP Remove `eyre` from Ethereum Bridge VP Remove `eyre` from Ethereum Bridge param errs Add a simple allocated storage err
tzemanovic
added a commit
that referenced
this pull request
Apr 1, 2024
* origin/tiago/vps-use-storage-err: Changelog for #2852 Remove `eyre` from Ethereum Bridge Pool VP Remove `eyre` from NUT VP Remove `eyre` from Ethereum Bridge VP Remove `eyre` from Ethereum Bridge param errs Add a simple allocated storage err
tzemanovic
added a commit
that referenced
this pull request
Apr 10, 2024
* origin/tiago/vps-use-storage-err: Changelog for #2852 Remove `eyre` from Ethereum Bridge Pool VP Remove `eyre` from NUT VP Remove `eyre` from Ethereum Bridge VP Remove `eyre` from Ethereum Bridge param errs Add a simple allocated storage err
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Replace
eyre!()errors withnamada_storageerrors. This change will be useful in a future PR, to allow easily downcasting to the error contained in a boxednamada_storageresult.Indicate on which release or other PRs this topic is based on
v0.32.0Checklist before merging to
draft