Remove the superfluous addition of .0 to Ledger test vectors.#2932
Merged
tzemanovic merged 2 commits intomainfrom Apr 12, 2024
Merged
Remove the superfluous addition of .0 to Ledger test vectors.#2932tzemanovic merged 2 commits intomainfrom
tzemanovic merged 2 commits intomainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2932 +/- ##
=======================================
Coverage 53.44% 53.44%
=======================================
Files 310 310
Lines 101574 101574
=======================================
+ Hits 54288 54289 +1
+ Misses 47286 47285 -1 ☔ View full report in Codecov by Sentry. |
karbyshev
approved these changes
Mar 21, 2024
tzemanovic
approved these changes
Mar 22, 2024
tzemanovic
added a commit
that referenced
this pull request
Apr 1, 2024
* origin/murisi/fix-ledger-significant-digits: Added changelog entry. Remove the superfluous addition of .0 to Ledger test vectors.
tzemanovic
added a commit
that referenced
this pull request
Apr 10, 2024
* origin/murisi/fix-ledger-significant-digits: Added changelog entry. Remove the superfluous addition of .0 to Ledger test vectors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Modified the printing of numbers in Ledger test vectors so that the
.0suffix is not added to whole numbers. So now all unnecessary zeros and decimals at the end of decimal numbers are removed before printing.Indicate on which release or other PRs this topic is based on
Namada v0.32.0
Checklist before merging to
draft