Skip to content

Compile gas adjustments#2982

Merged
tzemanovic merged 27 commits intomainfrom
grarco/gas-minor-adjustments
Apr 12, 2024
Merged

Compile gas adjustments#2982
tzemanovic merged 27 commits intomainfrom
grarco/gas-minor-adjustments

Conversation

@grarco
Copy link
Copy Markdown
Collaborator

@grarco grarco commented Apr 2, 2024

Describe your changes

Simplifies and anticipates gas charging when loading the wasm code.

Indicate on which release or other PRs this topic is based on

#2838 (diff: https://github.com/anoma/namada/pull/2982/files/eb302a8857405b0d13c7ca8c163234cac90168ca..88a6457277ac0170a5bbc35592fbd3d1656affde)

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 53.54839% with 216 lines in your changes are missing coverage. Please review.

Project coverage is 53.94%. Comparing base (cc3edde) to head (cc9324f).
Report is 117 commits behind head on main.

❗ Current head cc9324f differs from pull request most recent head 88a6457. Consider uploading reports for the commit 88a6457 to get more accurate results

Files Patch % Lines
crates/namada/src/vm/wasm/run.rs 62.02% 90 Missing ⚠️
crates/apps/src/lib/bench_utils.rs 0.00% 76 Missing ⚠️
crates/sdk/src/masp.rs 0.00% 27 Missing ⚠️
crates/namada/src/ledger/native_vp/ibc/context.rs 63.63% 8 Missing ⚠️
crates/macros/src/lib.rs 0.00% 6 Missing ⚠️
crates/apps/src/lib/node/ledger/mod.rs 0.00% 5 Missing ⚠️
crates/namada/src/ledger/native_vp/masp.rs 0.00% 3 Missing ⚠️
crates/namada/src/vm/host_env.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2982      +/-   ##
==========================================
+ Coverage   53.88%   53.94%   +0.05%     
==========================================
  Files         308      308              
  Lines      100154   100461     +307     
==========================================
+ Hits        53967    54190     +223     
- Misses      46187    46271      +84     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grarco grarco requested a review from tzemanovic April 2, 2024 14:43
@grarco grarco marked this pull request as ready for review April 2, 2024 14:43
tzemanovic added a commit that referenced this pull request Apr 3, 2024
* origin/grarco/gas-minor-adjustments:
  Changelog #2982
  Simplify gas metering in code fetch
tzemanovic added a commit that referenced this pull request Apr 10, 2024
* origin/grarco/gas-minor-adjustments:
  Changelog #2982
  Simplify gas metering in code fetch

# Conflicts:
#	crates/namada/src/vm/wasm/run.rs
@tzemanovic tzemanovic merged commit 1e54217 into main Apr 12, 2024
@tzemanovic tzemanovic deleted the grarco/gas-minor-adjustments branch April 12, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants