Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3102 +/- ##
==========================================
+ Coverage 59.41% 59.61% +0.20%
==========================================
Files 298 300 +2
Lines 92326 92917 +591
==========================================
+ Hits 54853 55394 +541
- Misses 37473 37523 +50 ☔ View full report in Codecov by Sentry. |
Collaborator
Author
|
ci is temporarily borked due to |
Fraccaman
pushed a commit
that referenced
this pull request
Apr 22, 2024
tzemanovic
reviewed
Apr 22, 2024
tzemanovic
previously approved these changes
Apr 22, 2024
grarco
reviewed
Apr 22, 2024
grarco
previously approved these changes
Apr 22, 2024
Collaborator
grarco
left a comment
There was a problem hiding this comment.
Just one comment but looks good to me!
44d0cdb to
401b042
Compare
401b042 to
593c6fd
Compare
batconjurer
reviewed
Apr 23, 2024
batconjurer
previously approved these changes
Apr 23, 2024
2 tasks
Co-authored-by: yito88 <yuji@phact-columba.com>
593c6fd to
3c0c5be
Compare
3c0c5be to
68420a5
Compare
brentstone
pushed a commit
that referenced
this pull request
Apr 30, 2024
brentstone
added a commit
that referenced
this pull request
May 8, 2024
* origin/tiago/move-events-to-submodules: Changelog for #3102 Use new events API in benches Re-export `namada_events` crate from `namada` Move events to their own crate Move Governance events to the appropriate crate Move Eth Bridge events to the appropriate crate Move IBC events to the appropriate crate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Move
Eventand associated types fromnamada_coreto the newnamada_eventscrate. Module-specific events (such asIbcEventandEthBridgeEvent) were moved to their respective crates (namada_ibcandnamada_ethereum_bridge).NOTE: IBC e2e tests are expected to fail, just like in the base PR.Indicate on which release or other PRs this topic is based on
#3088
Diff for review: https://github.com/anoma/namada/compare/tiago/emit-generic-events-wasm..tiago/move-events-to-submodules (https://github.com/anoma/namada/pull/3102/files/0ac23e8a2d514d30a94abb42eafc8c0d6f5ccebd..44d0cdbce373910043013bc75da8cd91a4408cee)
Checklist before merging to
draft