Skip to content

Move events to submodules#3102

Merged
brentstone merged 74 commits intomainfrom
tiago/move-events-to-submodules
May 9, 2024
Merged

Move events to submodules#3102
brentstone merged 74 commits intomainfrom
tiago/move-events-to-submodules

Conversation

@sug0
Copy link
Copy Markdown
Collaborator

@sug0 sug0 commented Apr 20, 2024

Describe your changes

Move Event and associated types from namada_core to the new namada_events crate. Module-specific events (such as IbcEvent and EthBridgeEvent) were moved to their respective crates (namada_ibc and namada_ethereum_bridge).

NOTE: IBC e2e tests are expected to fail, just like in the base PR.

Indicate on which release or other PRs this topic is based on

#3088

Diff for review: https://github.com/anoma/namada/compare/tiago/emit-generic-events-wasm..tiago/move-events-to-submodules (https://github.com/anoma/namada/pull/3102/files/0ac23e8a2d514d30a94abb42eafc8c0d6f5ccebd..44d0cdbce373910043013bc75da8cd91a4408cee)

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 20, 2024

Codecov Report

Attention: Patch coverage is 62.74876% with 599 lines in your changes are missing coverage. Please review.

Project coverage is 59.61%. Comparing base (ea843f7) to head (68420a5).
Report is 7 commits behind head on main.

Files Patch % Lines
crates/ibc/src/event.rs 46.94% 113 Missing ⚠️
...tes/apps/src/lib/node/ledger/shell/testing/node.rs 0.00% 88 Missing ⚠️
crates/events/src/extend.rs 73.96% 88 Missing ⚠️
crates/events/src/lib.rs 72.68% 62 Missing ⚠️
crates/governance/src/event.rs 52.21% 54 Missing ⚠️
crates/sdk/src/rpc.rs 0.00% 32 Missing ⚠️
...s/apps/src/lib/node/ledger/shell/finalize_block.rs 29.41% 24 Missing ⚠️
crates/sdk/src/events/log/dumb_queries.rs 82.75% 20 Missing ⚠️
crates/sdk/src/masp.rs 0.00% 18 Missing ⚠️
crates/ethereum_bridge/src/event.rs 71.69% 15 Missing ⚠️
... and 16 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3102      +/-   ##
==========================================
+ Coverage   59.41%   59.61%   +0.20%     
==========================================
  Files         298      300       +2     
  Lines       92326    92917     +591     
==========================================
+ Hits        54853    55394     +541     
- Misses      37473    37523      +50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sug0 sug0 changed the title Tiago/move events to submodules Move events to submodules Apr 22, 2024
@sug0 sug0 added enhancement New feature or request breaking-change labels Apr 22, 2024
sug0 added a commit that referenced this pull request Apr 22, 2024
@sug0 sug0 marked this pull request as ready for review April 22, 2024 08:06
@sug0
Copy link
Copy Markdown
Collaborator Author

sug0 commented Apr 22, 2024

ci is temporarily borked due to sccache

Fraccaman pushed a commit that referenced this pull request Apr 22, 2024
@Fraccaman Fraccaman mentioned this pull request Apr 22, 2024
2 tasks
tzemanovic
tzemanovic previously approved these changes Apr 22, 2024
grarco
grarco previously approved these changes Apr 22, 2024
Copy link
Copy Markdown
Collaborator

@grarco grarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment but looks good to me!

sug0 added a commit that referenced this pull request Apr 23, 2024
@sug0 sug0 dismissed stale reviews from grarco and tzemanovic via 401b042 April 23, 2024 08:17
@sug0 sug0 force-pushed the tiago/move-events-to-submodules branch from 44d0cdb to 401b042 Compare April 23, 2024 08:17
sug0 added a commit that referenced this pull request Apr 23, 2024
@sug0 sug0 force-pushed the tiago/move-events-to-submodules branch from 401b042 to 593c6fd Compare April 23, 2024 08:36
batconjurer
batconjurer previously approved these changes Apr 23, 2024
sug0 added a commit that referenced this pull request Apr 29, 2024
@sug0 sug0 force-pushed the tiago/move-events-to-submodules branch from 593c6fd to 3c0c5be Compare April 29, 2024 12:45
@sug0 sug0 marked this pull request as draft April 30, 2024 10:14
@sug0 sug0 force-pushed the tiago/move-events-to-submodules branch from 3c0c5be to 68420a5 Compare April 30, 2024 10:16
@sug0 sug0 marked this pull request as ready for review April 30, 2024 11:19
brentstone added a commit that referenced this pull request May 8, 2024
* origin/tiago/move-events-to-submodules:
  Changelog for #3102
  Use new events API in benches
  Re-export `namada_events` crate from `namada`
  Move events to their own crate
  Move Governance events to the appropriate crate
  Move Eth Bridge events to the appropriate crate
  Move IBC events to the appropriate crate
@brentstone brentstone merged commit eb44423 into main May 9, 2024
@brentstone brentstone deleted the tiago/move-events-to-submodules branch May 9, 2024 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-change enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants