Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3104 +/- ##
==========================================
+ Coverage 59.41% 59.61% +0.20%
==========================================
Files 298 300 +2
Lines 92326 92930 +604
==========================================
+ Hits 54853 55400 +547
- Misses 37473 37530 +57 ☔ View full report in Codecov by Sentry. |
sug0
previously approved these changes
Apr 23, 2024
Collaborator
sug0
left a comment
There was a problem hiding this comment.
ok, that was my only real complaint.
btw make sure to rebase again, when this eventually is ready. I've changed the base a few times due to review comments, already, so your base has diverged from mine.
Collaborator
Author
|
@sug0 can we cherry pick my commit to ur branch? its gonna make it easier |
Co-authored-by: yito88 <yuji@phact-columba.com>
9f92652 to
f30c3ec
Compare
f30c3ec to
ccc34a1
Compare
brentstone
added a commit
that referenced
this pull request
Apr 30, 2024
* fraccaman/governance-events: changelog: add #3104 goveranance: refactor and improve events
brentstone
added a commit
that referenced
this pull request
May 8, 2024
* origin/fraccaman/governance-events: changelog: add #3104 goveranance: refactor and improve events
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Refactor governance events.
Indicate on which release or other PRs this topic is based on
Based on #3102
Checklist before merging to
draft