Conversation
|
gaia is missing in this branch -.- |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3171 +/- ##
==========================================
+ Coverage 59.40% 59.62% +0.21%
==========================================
Files 298 298
Lines 92326 91988 -338
==========================================
+ Hits 54849 54850 +1
+ Misses 37477 37138 -339 ☔ View full report in Codecov by Sentry. |
|
rebase on |
@Fraccaman I'm based on #3142, but its base is outdated (before |
Co-authored-by: Gianmarco Fraccaroli <gianmarco@heliax.dev>
ca80e5c to
0d40c77
Compare
|
Changed the base to 5268b6d, which is |
e6488ac to
65ce1d7
Compare
|
@yito88 I'm not sure why, but |
|
#3142 requires updating Hermes. |
|
I see. thanks! |
* fraccaman/rework-balance: Changelog for #3171 Fix integration tests Standardize no balance response Improve error msg when no balance owner is found Remove `get_token_balance` from apps Remove IBC token query command Refactor the CLI's balance command
* origin/fraccaman/rework-balance: Changelog for #3171 Fix integration tests Standardize no balance response Improve error msg when no balance owner is found Remove `get_token_balance` from apps Remove IBC token query command Refactor the CLI's balance command
Describe your changes
Closes #3014
All balance queries now expect a
tokenand anownerparameter.Remove unbounded balance queries, where either (or both)
tokenandownerparameters could be omitted from the CLI args. We also remove unbounded IBC token queries: the SDK's functionality to query them remains untouched, but it is no longer exposed from the CLI.Indicate on which release or other PRs this topic is based on
#3142 (at 5268b6d; remove this commit and rebase on
origin/grarco/remove-pin-keyor a later release with the dep, egv0.35.0, when cutting a release with this PR)Diff for review: https://github.com/anoma/namada/compare/5268b6de791e2db48d6c979c4f97e92658b3c171..fraccaman/rework-balance
Checklist before merging to
draft