Remove masp vp dependency on Transfer#3232
Merged
brentstone merged 13 commits intomainfrom May 31, 2024
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3232 +/- ##
==========================================
+ Coverage 53.89% 53.93% +0.03%
==========================================
Files 314 314
Lines 105704 105739 +35
==========================================
+ Hits 56968 57027 +59
+ Misses 48736 48712 -24 ☔ View full report in Codecov by Sentry. |
grarco
force-pushed
the
grarco/masp-no-transfer-dep
branch
2 times, most recently
from
f4eeb94 to
9989051
Compare
grarco
force-pushed
the
grarco/masp-no-transfer-dep
branch
from
375182e to
4bf8fcc
Compare
tzemanovic
approved these changes
May 24, 2024
grarco
added a commit
that referenced
this pull request
May 24, 2024
grarco
added a commit
that referenced
this pull request
May 24, 2024
batconjurer
approved these changes
May 28, 2024
brentstone
added a commit
that referenced
this pull request
May 30, 2024
* origin/grarco/masp-no-transfer-dep: Fmt Changelog #3232 Fixes broken doc link Reworks masp tx indexing Helper function for masp action handling Moves masp events data to core Misc refactors Updates sdk to retrieve masp data based on events Emit masp sections references in the events Removes unused error variant Updates wasm transaction to push masp action Removes masp vp dependency on `Transfer` Adds new masp `Action`
brentstone
added a commit
that referenced
this pull request
May 30, 2024
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Closes #3148.
Partially addresses #2597.
Removes the last dependency on
Transferfrom the masp vp by using a new maspAction. Creates a new event for this and updated the sdk to fetch data relying on this event.Indicate on which release or other PRs this topic is based on
v0.37.0
Checklist before merging to
draft