remove deprecated dependency from app crate#3305
Merged
brentstone merged 2 commits intomainfrom May 31, 2024
Merged
Conversation
This was referenced May 24, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3305 +/- ##
==========================================
- Coverage 53.89% 53.89% -0.01%
==========================================
Files 314 314
Lines 105704 105706 +2
==========================================
Hits 56968 56968
- Misses 48736 48738 +2 ☔ View full report in Codecov by Sentry. |
cwgoes
approved these changes
May 27, 2024
brentstone
approved these changes
May 28, 2024
brentstone
added a commit
that referenced
this pull request
May 28, 2024
* stanisloe-2999: changelog: add #3305 remove deprecated dependency from app crate
brentstone
added a commit
that referenced
this pull request
May 30, 2024
* origin/stanisloe-2999: changelog: add #3305 remove deprecated dependency from app crate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Rebased from #2999 as I couldn't push to source branch.
Closes #2993
As discussed in linked issue
yaml-rustis not maintened and poses a risk as future vulnerabilities or bugs in yaml-rust will not be addressed. Also it makes noise if you runcargo-audit. As advised in RUSTSEC-2024-0320yaml-rust2is a fully compliant YAML 1.2 implementation written in rust and works faster than its predecessoryaml-rustand fully compatible with it.crates/appis the affected crate and it fetchesyaml-rustfromconfigcrate.I've udpated
configcrate to the latest version and fixed compilation errors and warnings.The reason why I'm using commit version instead of release tag for
configcrate is that it's owner is looking for new maintainer and not releasing new tags until than. Butyaml-rust2issue was tested and merged to main branch from this pr so it should be safe to use.Indicate on which release or other PRs this topic is based on
v0.37.0
Checklist before merging to
draft