Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3331 +/- ##
=======================================
Coverage 53.89% 53.89%
=======================================
Files 314 314
Lines 105704 105704
=======================================
Hits 56967 56967
Misses 48737 48737 ☔ View full report in Codecov by Sentry. |
Fraccaman
requested review from
sug0 and
tzemanovic
and removed request for
tzemanovic
Fraccaman
changed the title
wee_alloc in favor of rlsfwee_alloc in favor of rlsf
tzemanovic
reviewed
May 29, 2024
tzemanovic
previously approved these changes
May 29, 2024
sug0
previously approved these changes
May 29, 2024
Collaborator
sug0
left a comment
sug0
left a comment
There was a problem hiding this comment.
lgtm. just a nit (same as tomas')
tzemanovic
force-pushed
the
fraccaman/replace-wee-alloc
branch
from
21020de to
5f8a798
Compare
tzemanovic
previously approved these changes
May 30, 2024
tzemanovic
reviewed
May 30, 2024
brentstone
added a commit
that referenced
this pull request
May 30, 2024
* fraccaman/replace-wee-alloc: wasm_for_tests: delete old unused `wasm_source/Cargo.toml` changelog: add #3331 switch wee_alloc for rlsf
brentstone
added a commit
that referenced
this pull request
May 30, 2024
* origin/fraccaman/replace-wee-alloc: wasm_for_tests: delete old unused `wasm_source/Cargo.toml` changelog: add #3331 switch wee_alloc for rlsf
brentstone
added a commit
that referenced
this pull request
May 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Closes #808.
Closes #401.
Indicate on which release or other PRs this topic is based on
0.37.0
Checklist before merging to
draft