Skip to content

Allow NAM transfers for protocol actions in Multitoken VP#3348

Merged
brentstone merged 3 commits intomainfrom
tiago/allow-protocol-nam-transf
Jun 6, 2024
Merged

Allow NAM transfers for protocol actions in Multitoken VP#3348
brentstone merged 3 commits intomainfrom
tiago/allow-protocol-nam-transf

Conversation

@sug0
Copy link
Copy Markdown
Collaborator

@sug0 sug0 commented Jun 2, 2024

Describe your changes

Closes #3329

Indicate on which release or other PRs this topic is based on

v0.38.1

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@sug0 sug0 requested review from brentstone, tzemanovic and yito88 June 2, 2024 15:55
sug0 added a commit that referenced this pull request Jun 2, 2024
@sug0 sug0 changed the title Multitoken VP: Allow NAM transfers for protocol actions Allow NAM transfers for protocol actions in Multitoken VP Jun 2, 2024
@sug0 sug0 marked this pull request as ready for review June 2, 2024 15:56
@cwgoes cwgoes mentioned this pull request Jun 2, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 2, 2024

Codecov Report

Attention: Patch coverage is 94.92754% with 7 lines in your changes missing coverage. Please review.

Project coverage is 54.10%. Comparing base (883bd0f) to head (0ac0184).

Files Patch % Lines
crates/namada/src/ledger/native_vp/multitoken.rs 94.92% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3348      +/-   ##
==========================================
+ Coverage   54.05%   54.10%   +0.05%     
==========================================
  Files         315      315              
  Lines      106296   106428     +132     
==========================================
+ Hits        57461    57586     +125     
- Misses      48835    48842       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sug0 added a commit that referenced this pull request Jun 3, 2024
@sug0 sug0 force-pushed the tiago/allow-protocol-nam-transf branch from 8c51167 to ae7ab1c Compare June 3, 2024 13:11
tzemanovic
tzemanovic previously approved these changes Jun 3, 2024
Fraccaman added a commit that referenced this pull request Jun 3, 2024
* up/tiago/allow-protocol-nam-transf:
  Changelog for #3348
  Multitoken VP: Allow NAM transfers for protocol actions
sug0 added a commit that referenced this pull request Jun 4, 2024
@sug0 sug0 force-pushed the tiago/allow-protocol-nam-transf branch from 9778340 to d184613 Compare June 4, 2024 09:16
@sug0 sug0 force-pushed the tiago/allow-protocol-nam-transf branch from d184613 to 0ac0184 Compare June 4, 2024 09:21
brentstone added a commit that referenced this pull request Jun 4, 2024
* tiago/allow-protocol-nam-transf:
  Changelog for #3348
  Fix balance change logic
  Multitoken VP: Allow NAM transfers for protocol actions
brentstone added a commit that referenced this pull request Jun 5, 2024
* origin/tiago/allow-protocol-nam-transf:
  Changelog for #3348
  Fix balance change logic
  Multitoken VP: Allow NAM transfers for protocol actions
@brentstone brentstone merged commit e4e50a3 into main Jun 6, 2024
@brentstone brentstone deleted the tiago/allow-protocol-nam-transf branch June 6, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow PoS to be the source of transfers before phase 5

4 participants