Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3375 +/- ##
==========================================
- Coverage 53.92% 53.91% -0.02%
==========================================
Files 317 317
Lines 107575 107634 +59
==========================================
+ Hits 58011 58026 +15
- Misses 49564 49608 +44 ☔ View full report in Codecov by Sentry. |
brentstone
force-pushed
the
tomas/masp-total-rewards
branch
from
35bd91a to
054f915
Compare
Closed
Collaborator
|
Are we only waiting for review here? |
Collaborator
Author
yeah, I'll add a changelog |
murisi
approved these changes
Jun 7, 2024
Collaborator
murisi
left a comment
murisi
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks!
brentstone
added a commit
that referenced
this pull request
Jun 7, 2024
* tomas/masp-total-rewards: changelog: add #3375 client/rpc: print MASP total rewards in conversions query sdk: add a query for MASP total rewards shielded_token: store the total rewards minted by MASP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
closes #1730
Additionally, the original impl didn't increment the token total supply with the minted reward. This is fixed by using the
fn credit_tokensthat takes care of it.Indicate on which release or other PRs this topic is based on
v0.39.0
Checklist before merging to
draft