Merged
Conversation
tzemanovic
previously approved these changes
Jun 6, 2024
2 tasks
Closed
Co-authored-by: Tiago Carvalho <sugoiuguu@tfwno.gf>
Co-authored-by: Tiago Carvalho <sugoiuguu@tfwno.gf>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3383 +/- ##
==========================================
+ Coverage 53.92% 53.93% +0.01%
==========================================
Files 317 317
Lines 107575 107786 +211
==========================================
+ Hits 58011 58137 +126
- Misses 49564 49649 +85 ☔ View full report in Codecov by Sentry. |
sug0
approved these changes
Jun 13, 2024
brentstone
added a commit
that referenced
this pull request
Jun 25, 2024
* bat/feat/db-snapshots: addressing review comment review comments Update crates/node/src/storage/rocksdb.rs Update crates/node/src/storage/rocksdb.rs changelog [feat]: Added snapshot frequency to config [feat]: Added ability to create snapshots of rocksDb WIP
brentstone
added a commit
that referenced
this pull request
Jun 25, 2024
* bat/feat/db-snapshots: addressing review comment review comments Update crates/node/src/storage/rocksdb.rs Update crates/node/src/storage/rocksdb.rs changelog [feat]: Added snapshot frequency to config [feat]: Added ability to create snapshots of rocksDb WIP
brentstone
added a commit
that referenced
this pull request
Jun 25, 2024
* bat/feat/db-snapshots: addressing review comment review comments Update crates/node/src/storage/rocksdb.rs Update crates/node/src/storage/rocksdb.rs changelog [feat]: Added snapshot frequency to config [feat]: Added ability to create snapshots of rocksDb WIP
brentstone
added a commit
that referenced
this pull request
Jul 4, 2024
* origin/bat/feat/db-snapshots: addressing review comment review comments Update crates/node/src/storage/rocksdb.rs Update crates/node/src/storage/rocksdb.rs changelog [feat]: Added snapshot frequency to config [feat]: Added ability to create snapshots of rocksDb WIP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Resolves the first two points of Issue #3307:
Specifically adds a config parameter that indicates after how many blocks a snapshot should be created. If set, then on the corresponding calls to
commit, a background task is spun up that takes a snapshot of rocksDB and writes it in a convenient format to a file. This file contains metadata of how to be broken up into chunks. Once a new snapshot is created, older snapshots are removed.Indicate on which release or other PRs this topic is based on
v0.39.0
Checklist before merging to
draft