Closed
Conversation
1ebcb5e to
d15774f
Compare
d15774f to
29a64eb
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3446 +/- ##
==========================================
- Coverage 53.92% 53.88% -0.05%
==========================================
Files 317 317
Lines 107575 107645 +70
==========================================
- Hits 58011 58005 -6
- Misses 49564 49640 +76 ☔ View full report in Codecov by Sentry. |
Closed
cwgoes
previously approved these changes
Jun 28, 2024
Collaborator
cwgoes
left a comment
There was a problem hiding this comment.
Conceptual ACK - much, much cleaner!
grarco
reviewed
Jul 1, 2024
grarco
reviewed
Jul 1, 2024
| token, | ||
| amount, | ||
| } in data | ||
| { |
Collaborator
There was a problem hiding this comment.
Just a note: I think I've improved this in #3393 by trying to group the same sources/tokens before looking for the available notes
grarco
reviewed
Jul 1, 2024
grarco
previously approved these changes
Jul 1, 2024
tzemanovic
reviewed
Jul 1, 2024
tzemanovic
previously approved these changes
Jul 1, 2024
6436e48 to
6110726
Compare
Collaborator
|
Closing in favor of #3459 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Attempt to simplify the combination of split MASP transfers and vectorized transfers. The main change is to make a transfer format that allows shielded operations to be done in the presence of both transparent inputs and transparent outputs. All the other transfer formats are then subsumed into this one.
Indicate on which release or other PRs this topic is based on
#3356
Checklist before merging to
draft