Avoid multiple calls to process_proposal#3473
Merged
brentstone merged 12 commits intomainfrom Jul 24, 2024
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3473 +/- ##
==========================================
- Coverage 53.48% 53.41% -0.08%
==========================================
Files 320 320
Lines 110000 110160 +160
==========================================
+ Hits 58832 58840 +8
- Misses 51168 51320 +152 ☔ View full report in Codecov by Sentry. |
sug0
requested changes
Jul 3, 2024
Collaborator
Author
|
@sug0 I've pushed a few more commits to change some things on top of your recommendations:
Let me know if they are ok or it's better to revert the last commits |
8674109 to
5523e05
Compare
Closed
brentstone
added a commit
that referenced
this pull request
Jul 10, 2024
* grarco/opt-validation-calls: Changelog #3473 Renames process proposal cache LRU process proposal cache Custom type for process proposal result cache Cache of process proposal uses results Refactors process proposal check in a separate function Avoids full clone of the entire block in process proposal Cache check in `try_recheck_process_proposal` Cache result of `process_proposal` New type for process proposal rechecks Removes redundant `votes` field from `FinalizeBlock` request Rechecks with `process_proposal` instead of `process_txs`
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR tries to improve the extra calls to process proposal requested by Namada (nothing changes for the requests coming from Comet). More specifically:
process_proposalis now called instead ofprocess_txsInMemorystruct has been expanded with an extra field that caches the requests toprocess_proposalfor a given block so that future calls can be avoided. This cache is cleared when handling aFinalizeBlockrequestIndicate on which release or other PRs this topic is based on
v0.40.0Checklist before merging to
draft