Skip to content

Improve governance client validation#3629

Merged
mergify[bot] merged 2 commits intomainfrom
fraccaman/improve-init-proposal-validation
Aug 14, 2024
Merged

Improve governance client validation#3629
mergify[bot] merged 2 commits intomainfrom
fraccaman/improve-init-proposal-validation

Conversation

@Fraccaman
Copy link
Copy Markdown
Collaborator

Describe your changes

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes

@Fraccaman Fraccaman force-pushed the fraccaman/improve-init-proposal-validation branch from 164a2e8 to 06c8f95 Compare August 13, 2024 14:32
@Fraccaman Fraccaman requested a review from grarco August 13, 2024 14:46
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 31 lines in your changes missing coverage. Please review.

Project coverage is 61.27%. Comparing base (f08d3f2) to head (6e7002e).
Report is 37 commits behind head on main.

Files Patch % Lines
crates/sdk/src/rpc.rs 0.00% 24 Missing ⚠️
crates/governance/src/cli/onchain.rs 0.00% 3 Missing ⚠️
crates/governance/src/cli/validation.rs 0.00% 2 Missing ⚠️
crates/sdk/src/tx.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3629      +/-   ##
==========================================
- Coverage   61.28%   61.27%   -0.02%     
==========================================
  Files         312      312              
  Lines      101337   101328       -9     
==========================================
- Hits        62103    62084      -19     
- Misses      39234    39244      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Fraccaman Fraccaman force-pushed the fraccaman/improve-init-proposal-validation branch from 06c8f95 to 879dfeb Compare August 13, 2024 14:58
@Fraccaman Fraccaman force-pushed the fraccaman/improve-init-proposal-validation branch from 879dfeb to c7d9daf Compare August 14, 2024 10:30
@Fraccaman Fraccaman force-pushed the fraccaman/improve-init-proposal-validation branch from c7d9daf to 6e7002e Compare August 14, 2024 11:07
@Fraccaman Fraccaman requested a review from grarco August 14, 2024 12:09
Copy link
Copy Markdown
Collaborator

@grarco grarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tzemanovic tzemanovic added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Aug 14, 2024
mergify bot added a commit that referenced this pull request Aug 14, 2024
mergify bot added a commit that referenced this pull request Aug 14, 2024
@mergify mergify bot merged commit b44b022 into main Aug 14, 2024
@mergify mergify bot deleted the fraccaman/improve-init-proposal-validation branch August 14, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants