Skip to content

Fixes MASP tx expiration in the SDK#3724

Merged
mergify[bot] merged 12 commits intomainfrom
grarco/fix-masp-expiration
Sep 6, 2024
Merged

Fixes MASP tx expiration in the SDK#3724
mergify[bot] merged 12 commits intomainfrom
grarco/fix-masp-expiration

Conversation

@grarco
Copy link
Copy Markdown
Collaborator

@grarco grarco commented Aug 29, 2024

Describe your changes

Closes #3586.

  • Fixes a bug by which the SDK would not set the correct expiration to MASP Transactions
  • Adds an integration test for masp expiration
  • Removes some outdated assertions based on the old double-block execution scheme
  • Improves assertions on MockNode
  • Wraps MockNode into a single Arc

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 76.47059% with 4 lines in your changes missing coverage. Please review.

Project coverage is 72.49%. Comparing base (ef49b3d) to head (f41e88a).
Report is 34 commits behind head on main.

Files with missing lines Patch % Lines
crates/sdk/src/tx.rs 66.66% 2 Missing ⚠️
crates/shielded_token/src/masp/shielded_wallet.rs 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3724      +/-   ##
==========================================
- Coverage   72.50%   72.49%   -0.01%     
==========================================
  Files         338      338              
  Lines      104190   104191       +1     
==========================================
- Hits        75541    75538       -3     
- Misses      28649    28653       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

grarco added a commit that referenced this pull request Aug 30, 2024
@grarco grarco marked this pull request as ready for review August 30, 2024 14:48
@grarco grarco requested review from sug0 and yito88 August 30, 2024 15:26
grarco added a commit that referenced this pull request Sep 2, 2024
@grarco grarco force-pushed the grarco/fix-masp-expiration branch from c25d66e to 50a5ff8 Compare September 2, 2024 10:01
Copy link
Copy Markdown
Collaborator

@sug0 sug0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of suggestions + comments

grarco added a commit that referenced this pull request Sep 4, 2024
@grarco grarco force-pushed the grarco/fix-masp-expiration branch from 314e7ad to 4d6930d Compare September 4, 2024 18:22
@sug0 sug0 self-requested a review September 5, 2024 09:09
grarco added a commit that referenced this pull request Sep 6, 2024
@grarco grarco force-pushed the grarco/fix-masp-expiration branch from 4d6930d to e8a3164 Compare September 6, 2024 09:06
@grarco grarco force-pushed the grarco/fix-masp-expiration branch from e8a3164 to f41e88a Compare September 6, 2024 14:44
@grarco grarco added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Sep 6, 2024
mergify bot added a commit that referenced this pull request Sep 6, 2024
@mergify mergify bot merged commit ee4649b into main Sep 6, 2024
@mergify mergify bot deleted the grarco/fix-masp-expiration branch September 6, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MASP txs do not respect tx expiration date set in args

3 participants