Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3752 +/- ##
==========================================
+ Coverage 72.42% 72.43% +0.01%
==========================================
Files 335 335
Lines 104005 104005
==========================================
+ Hits 75322 75334 +12
+ Misses 28683 28671 -12 ☔ View full report in Codecov by Sentry. |
sug0
requested changes
Sep 4, 2024
brentstone
added a commit
that referenced
this pull request
Sep 5, 2024
25c24dd to
adbff4b
Compare
adbff4b to
fe0feae
Compare
sug0
approved these changes
Sep 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Just don't build it anymore, can easily incorporate back into
namada_appsif we decide to use it in the future.Checklist before merging
breaking::labels