Skip to content

Increasing code coverage in sdk/signing#3924

Merged
mergify[bot] merged 4 commits intomainfrom
bat/increase-coverage-core-signing
Oct 18, 2024
Merged

Increasing code coverage in sdk/signing#3924
mergify[bot] merged 4 commits intomainfrom
bat/increase-coverage-core-signing

Conversation

@batconjurer
Copy link
Copy Markdown
Collaborator

@batconjurer batconjurer commented Oct 16, 2024

Describe your changes

Increase code coverage in crats/core/signing.rs

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 96.81934% with 25 lines in your changes missing coverage. Please review.

Project coverage is 73.83%. Comparing base (81467ed) to head (befc9d8).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
crates/sdk/src/signing.rs 97.31% 21 Missing ⚠️
crates/wallet/src/lib.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3924      +/-   ##
==========================================
+ Coverage   73.25%   73.83%   +0.58%     
==========================================
  Files         341      341              
  Lines      105334   106114     +780     
==========================================
+ Hits        77158    78350    +1192     
+ Misses      28176    27764     -412     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tzemanovic tzemanovic changed the title Increasing code coverage in core/signing Increasing code coverage in sdk/signing Oct 17, 2024
@tzemanovic tzemanovic added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Oct 18, 2024
mergify bot added a commit that referenced this pull request Oct 18, 2024
@mergify mergify bot merged commit 25b873d into main Oct 18, 2024
@mergify mergify bot deleted the bat/increase-coverage-core-signing branch October 18, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants