Skip to content

Small misc fixes#3940

Merged
mergify[bot] merged 7 commits intomainfrom
brent/small-tings
Oct 24, 2024
Merged

Small misc fixes#3940
mergify[bot] merged 7 commits intomainfrom
brent/small-tings

Conversation

@brentstone
Copy link
Copy Markdown
Collaborator

@brentstone brentstone commented Oct 22, 2024

Describe your changes

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.02%. Comparing base (c465b7d) to head (99a4dc9).
Report is 28 commits behind head on main.

Files with missing lines Patch % Lines
crates/sdk/src/rpc.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3940      +/-   ##
==========================================
- Coverage   74.02%   74.02%   -0.01%     
==========================================
  Files         341      341              
  Lines      106560   106567       +7     
==========================================
+ Hits        78879    78884       +5     
- Misses      27681    27683       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brentstone brentstone added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Oct 24, 2024
mergify bot added a commit that referenced this pull request Oct 24, 2024
@mergify mergify bot merged commit 2107072 into main Oct 24, 2024
@mergify mergify bot deleted the brent/small-tings branch October 24, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

namadac query-protocol-parameters shows tx_allowlist instead of vp_allowlist

3 participants