Skip to content

Updated gas#3956

Merged
mergify[bot] merged 3 commits intomainfrom
grarco/adjusted-gas-prices
Nov 1, 2024
Merged

Updated gas#3956
mergify[bot] merged 3 commits intomainfrom
grarco/adjusted-gas-prices

Conversation

@grarco
Copy link
Copy Markdown
Collaborator

@grarco grarco commented Oct 28, 2024

Describe your changes

Updates genesis local files with the most update values for mainnet. Updates the DEFAULT_GAS_LIMIT in the sdk. Corrects tests.

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.99%. Comparing base (2107072) to head (762d6a4).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3956      +/-   ##
==========================================
- Coverage   74.00%   73.99%   -0.02%     
==========================================
  Files         341      341              
  Lines      106615   106614       -1     
==========================================
- Hits        78901    78888      -13     
- Misses      27714    27726      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brentstone
Copy link
Copy Markdown
Collaborator

So to summarize:

  • hard-coded DEFAULT_GAS_LIMIT = 50_000 from 250_000
  • max_block_gas: 15_000_000 --> 3_000_000
  • masp_fee_payment: 250_000 --> 50_000
  • gas_scale: 10_000 --> 50_000
  • Cost per gas unit in NAM = 10^-5 as before (but changed in our testing config)

So now, the cost for a simple tx by default is 0.5 NAM.

@grarco Can you explain again why MASP fee payment and gas scale are changed?

@grarco
Copy link
Copy Markdown
Collaborator Author

grarco commented Oct 29, 2024

Masp fee payment must be kept to a sensible value so that we are guaranteed that fee payment via the MASP happens in a reasonable amount of time. Gas scale was increased to reduce the gas used by transactions so that the fees could go down as well.

@brentstone
Copy link
Copy Markdown
Collaborator

@grarco is this rdy for merge?

@grarco
Copy link
Copy Markdown
Collaborator Author

grarco commented Nov 1, 2024

@grarco is this rdy for merge?

Yes it is

@brentstone brentstone added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Nov 1, 2024
@mergify mergify bot merged commit a148ac3 into main Nov 1, 2024
@mergify mergify bot deleted the grarco/adjusted-gas-prices branch November 1, 2024 21:54
mergify bot pushed a commit that referenced this pull request Nov 1, 2024
(cherry picked from commit 762d6a4)
@mergify mergify bot mentioned this pull request Nov 1, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass non-breaking-change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants