Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3956 +/- ##
==========================================
- Coverage 74.00% 73.99% -0.02%
==========================================
Files 341 341
Lines 106615 106614 -1
==========================================
- Hits 78901 78888 -13
- Misses 27714 27726 +12 ☔ View full report in Codecov by Sentry. |
Collaborator
|
So to summarize:
So now, the cost for a simple tx by default is 0.5 NAM. @grarco Can you explain again why MASP fee payment and gas scale are changed? |
Collaborator
Author
|
Masp fee payment must be kept to a sensible value so that we are guaranteed that fee payment via the MASP happens in a reasonable amount of time. Gas scale was increased to reduce the gas used by transactions so that the fees could go down as well. |
brentstone
approved these changes
Nov 1, 2024
Collaborator
|
@grarco is this rdy for merge? |
Collaborator
Author
Yes it is |
mergify bot
pushed a commit
that referenced
this pull request
Nov 1, 2024
(cherry picked from commit 762d6a4)
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Updates genesis local files with the most update values for mainnet. Updates the
DEFAULT_GAS_LIMITin the sdk. Corrects tests.Checklist before merging
breaking::labelsnamada-docsreponamada-indexerornamada-masp-indexer, a corresponding PR is opened in that repo