Merged
Conversation
tzemanovic
added a commit
that referenced
this pull request
Nov 4, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3971 +/- ##
=======================================
Coverage 73.99% 74.00%
=======================================
Files 341 341
Lines 106614 106634 +20
=======================================
+ Hits 78888 78910 +22
+ Misses 27726 27724 -2 ☔ View full report in Codecov by Sentry. |
brentstone
approved these changes
Nov 4, 2024
Contributor
|
Hey @tzemanovic, your pull request has been dequeued due to the following reason: CHECKS_FAILED. |
Collaborator
Author
|
@Mergifyio requeue |
Contributor
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
fixes #3953
The config-rs prefix separator behavior had a regression introduced after 0.11 rust-cli/config-rs#291 where instead of the previous single underscore prefix separator it was using the field separator with double underscore. The fix was introduced in rust-cli/config-rs#292 that allows to specify prefix separator.
Checklist before merging
breaking::labelsnamada-docsreponamada-indexerornamada-masp-indexer, a corresponding PR is opened in that repo