dump tx output for reveal_pk transactions when requested#4061
Merged
mergify[bot] merged 2 commits intonamada-net:mainfrom Nov 21, 2024
Merged
dump tx output for reveal_pk transactions when requested#4061mergify[bot] merged 2 commits intonamada-net:mainfrom
mergify[bot] merged 2 commits intonamada-net:mainfrom
Conversation
Contributor
Author
|
there are a few ways to implement this so wanted to add color to my choices. happy to change -
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4061 +/- ##
==========================================
+ Coverage 73.91% 74.31% +0.40%
==========================================
Files 341 341
Lines 106496 107401 +905
==========================================
+ Hits 78718 79817 +1099
+ Misses 27778 27584 -194 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
tzemanovic
reviewed
Nov 21, 2024
crates/apps_lib/src/client/tx.rs
Outdated
| if let Address::Implicit(ImplicitAddress(pkh)) = | ||
| &(&args.public_key).into() | ||
| { | ||
| let public_key = &namada |
Collaborator
There was a problem hiding this comment.
we don't need to look-up the PK as we already have it in args.public_key
aaf7679 to
3420f00
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
It is currently not possible to generate the
reveal_pktransaction offline. This PR will dump the transaction when requested.Checklist before merging
breaking::labelsnamada-docsreponamada-indexerornamada-masp-indexer, a corresponding PR is opened in that repo