Conversation
…sure removal of MASP Builder data.
…eters cannot be reused. Fixed MASP integration tests depending on access to secret keys.
… MASP hardware wallet integration functionality is triggered.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4127 +/- ##
==========================================
- Coverage 74.58% 74.49% -0.09%
==========================================
Files 341 341
Lines 107484 107645 +161
==========================================
+ Hits 80167 80192 +25
- Misses 27317 27453 +136 ☔ View full report in Codecov by Sentry. |
|
|
||
| /// Derives a masp spending key from the mnemonic code in the wallet. | ||
| fn shielded_key_derive( | ||
| async fn shielded_key_derive( |
There was a problem hiding this comment.
why did this become async?
There was a problem hiding this comment.
it's taken from #3797 without shielded keys support in HW wallet - we unfortunately already have some blocking calls mixed in the client already (e.g. wallet load) but I think we should just go with it and convert the blocking stuff to async
822426b to
53940be
Compare
53940be to
49a4a5d
Compare
mateuszjasiuk
left a comment
There was a problem hiding this comment.
Everything works great from perspective of frontend integration :)!
Describe your changes
Essentially #3797, but with MASP hardware wallet integration disabled. Hardware wallet integration was disabled because (modified) ZIP 32 derivations are not yet supported by the device. Despite this, this PR is still useful because it separates MASP transaction building from MASP transaction signing, which is required for securely implementing MASP transactions on Namadillo.
Checklist before merging
breaking::labelsnamada-docsreponamada-indexerornamada-masp-indexer, a corresponding PR is opened in that repo