Support invalid receivers in the IBC PFM flow#4134
Merged
mergify[bot] merged 13 commits intomainfrom Jan 20, 2025
Merged
Conversation
5 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4134 +/- ##
==========================================
- Coverage 74.59% 74.53% -0.06%
==========================================
Files 342 344 +2
Lines 108796 109256 +460
==========================================
+ Hits 81152 81433 +281
- Misses 27644 27823 +179 ☔ View full report in Codecov by Sentry. |
yito88
approved these changes
Dec 2, 2024
tzemanovic
approved these changes
Dec 3, 2024
grarco
approved these changes
Dec 3, 2024
a404896 to
a8ae15f
Compare
Collaborator
Author
|
(rebased on latest |
a8ae15f to
570eb19
Compare
batconjurer
pushed a commit
that referenced
this pull request
Dec 27, 2024
570eb19 to
d0a242f
Compare
This was referenced Jan 13, 2025
Co-authored-by: Jacob Turner <jacob.turner870@gmail.com>
Co-authored-by: Jacob Turner <jacob.turner870@gmail.com>
Co-authored-by: Jacob Turner <jacob.turner870@gmail.com>
Co-authored-by: Jacob Turner <jacob.turner870@gmail.com>
Co-authored-by: Jacob Turner <jacob.turner870@gmail.com> Co-authored-by: Yuji Ito <yuji@phact-columba.com>
Co-authored-by: Jacob Turner <jacob.turner870@gmail.com>
d0a242f to
6e1a56e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Based on #4082
In order to be compatible with the Osmosis XCS contracts, which set invalid
tnam1...addresses, we must disable validation of receivers, while handling PFM packets.Diff: https://github.com/anoma/namada/compare/bat+tiago/feat/ibc-pfm..bat+tiago/feat/ibc-pfm-with-invalid-addrs
Checklist before merging
breaking::labelsnamada-docsreponamada-indexerornamada-masp-indexer, a corresponding PR is opened in that repo