Add Ledger app unit tests to the Namada CI#4140
Merged
mergify[bot] merged 6 commits intomainfrom Dec 7, 2024
Merged
Conversation
dc0a4c3 to
74e0a37
Compare
74e0a37 to
f2db3ba
Compare
grarco
reviewed
Dec 3, 2024
| expiration in option::of(arb_date_time_utc()), | ||
| timestamp in arb_date_time_utc(), | ||
| batch in arb_tx_commitments(1..10), | ||
| batch in arb_tx_commitments(cmt_count), |
Collaborator
There was a problem hiding this comment.
Nice one here 👍🏻 , we were previously generating up to 10 headers and the other arb_transaction generators were only appending data for a single inner tx which was strange
grarco
approved these changes
Dec 3, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4140 +/- ##
==========================================
- Coverage 74.56% 74.54% -0.03%
==========================================
Files 341 341
Lines 107502 107549 +47
==========================================
+ Hits 80160 80173 +13
- Misses 27342 27376 +34 ☔ View full report in Codecov by Sentry. |
tzemanovic
reviewed
Dec 4, 2024
tzemanovic
approved these changes
Dec 4, 2024
Collaborator
|
Thanks murisi! I just want to make a couple of changes to the CI workflow before merging |
3 tasks
mergify bot
added a commit
that referenced
this pull request
Dec 11, 2024
Add Ledger app unit tests to the Namada CI (backport #4140)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
An attempt to add Ledger app unit tests to the Namada CI. These tests were created to complement the Ledger app E2E tests already in the CI at
test-e2e-with-device-automation. Whereas the E2E tests comprehensively cover testing hardware wallet signing for a few cases, these unit tests focus on covering hardware wallet printing for hundreds of cases. More specifically, the following changes have been made:See an example run of this new job here: https://github.com/murisi/namada/actions/runs/12143664343/job/33861086521?pr=2
Checklist before merging
breaking::labelsnamada-docsreponamada-indexerornamada-masp-indexer, a corresponding PR is opened in that repo