Skip to content

inline the borsh-ext fn in core#4177

Merged
tzemanovic merged 2 commits intomainfrom
tomas/inline-borsh-ext
Dec 11, 2024
Merged

inline the borsh-ext fn in core#4177
tzemanovic merged 2 commits intomainfrom
tomas/inline-borsh-ext

Conversation

@tzemanovic
Copy link
Copy Markdown
Collaborator

Describe your changes

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

@tzemanovic tzemanovic force-pushed the tomas/inline-borsh-ext branch from 1b81c55 to ce55dbc Compare December 11, 2024 19:41
@tzemanovic tzemanovic requested a review from sug0 December 11, 2024 19:43
@tzemanovic tzemanovic mentioned this pull request Dec 11, 2024
18 tasks
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.58%. Comparing base (b24938e) to head (ce55dbc).
Report is 103 commits behind head on main.

Files with missing lines Patch % Lines
crates/core/src/borsh.rs 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4177      +/-   ##
==========================================
+ Coverage   74.57%   74.58%   +0.01%     
==========================================
  Files         341      342       +1     
  Lines      107492   107504      +12     
==========================================
+ Hits        80157    80178      +21     
+ Misses      27335    27326       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Collaborator

@sug0 sug0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, cheers!

@tzemanovic tzemanovic added the backport-libs-0.251 Backport libraries to 0.251 maintenance branch label Dec 11, 2024
@tzemanovic tzemanovic merged commit 08c16b7 into main Dec 11, 2024
@tzemanovic tzemanovic deleted the tomas/inline-borsh-ext branch December 11, 2024 20:53
mergify bot pushed a commit that referenced this pull request Dec 11, 2024
(cherry picked from commit ce55dbc)

# Conflicts:
#	.github/workflows/ci.yml
#	.github/workflows/scripts/hermes.txt
#	.mergify.yml
#	CHANGELOG.md
#	Cargo.lock
#	Cargo.toml
#	README.md
#	crates/apps/Cargo.toml
#	crates/apps_lib/src/cli.rs
#	crates/apps_lib/src/cli/client.rs
#	crates/apps_lib/src/cli/context.rs
#	crates/apps_lib/src/cli/wallet.rs
#	crates/apps_lib/src/client/tx.rs
#	crates/apps_lib/src/client/utils.rs
#	crates/apps_lib/src/config/genesis/transactions.rs
#	crates/apps_lib/src/config/genesis/utils.rs
#	crates/apps_lib/src/wallet/defaults.rs
#	crates/benches/native_vps.rs
#	crates/core/src/masp.rs
#	crates/ibc/src/lib.rs
#	crates/node/src/bench_utils.rs
#	crates/node/src/shell/testing/client.rs
#	crates/sdk/src/args.rs
#	crates/sdk/src/lib.rs
#	crates/sdk/src/signing.rs
#	crates/sdk/src/tx.rs
#	crates/shielded_token/src/masp.rs
#	crates/shielded_token/src/masp/shielded_wallet.rs
#	crates/shielded_token/src/validation.rs
#	crates/tests/src/e2e/helpers.rs
#	crates/tests/src/e2e/ibc_tests.rs
#	crates/tests/src/e2e/ledger_tests.rs
#	crates/tests/src/e2e/setup.rs
#	crates/tests/src/integration/helpers.rs
#	crates/tests/src/integration/ledger_tests.rs
#	crates/tests/src/integration/masp.rs
#	crates/token/src/lib.rs
#	crates/tx/src/types.rs
#	crates/wallet/src/keys.rs
#	crates/wallet/src/lib.rs
#	crates/wallet/src/store.rs
#	genesis/hardware/src/pre-genesis/wallet.toml
#	genesis/localnet/balances.toml
#	genesis/localnet/src/pre-genesis/signed-transactions.toml
#	genesis/localnet/src/pre-genesis/unsigned-transactions.toml
#	genesis/localnet/src/pre-genesis/wallet.toml
#	genesis/localnet/transactions.toml
#	wasm/Cargo.lock
#	wasm_for_tests/Cargo.lock
tzemanovic added a commit that referenced this pull request Dec 11, 2024
mergify bot added a commit that referenced this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-libs-0.251 Backport libraries to 0.251 maintenance branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants