Skip to content

define and check minimum supported Rust version in CI#4398

Merged
mergify[bot] merged 3 commits intomainfrom
tomas/add-msrv
Feb 25, 2025
Merged

define and check minimum supported Rust version in CI#4398
mergify[bot] merged 3 commits intomainfrom
tomas/add-msrv

Conversation

@tzemanovic
Copy link
Copy Markdown
Collaborator

Describe your changes

Our current MSRV is 1.80 because of orion dep that requires it

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

@tzemanovic tzemanovic requested a review from Fraccaman February 18, 2025 12:34
tzemanovic added a commit that referenced this pull request Feb 18, 2025
@tzemanovic tzemanovic added the backport-libs-0.251 Backport libraries to 0.251 maintenance branch label Feb 18, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.53%. Comparing base (b5f4a7d) to head (f037759).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4398   +/-   ##
=======================================
  Coverage   74.52%   74.53%           
=======================================
  Files         339      339           
  Lines      110504   110504           
=======================================
+ Hits        82351    82359    +8     
+ Misses      28153    28145    -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tzemanovic
Copy link
Copy Markdown
Collaborator Author

I'll move this into the new workflow added in #4401 once it's merge as we only need it for main PRs

@tzemanovic
Copy link
Copy Markdown
Collaborator Author

tzemanovic commented Feb 25, 2025

the new CI job can-backport fails because the cherry-pick resolves conflict in Cargo.toml badly (configured with --strategy-option=theirs it takes the libs version = "0.47.0" which must be on version = "0.47.3". Using ours strategy also doesn't work in this case as that omits the newly added rust-version field instead)

@tzemanovic tzemanovic added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Feb 25, 2025
@mergify mergify bot merged commit 54f1f32 into main Feb 25, 2025
26 of 28 checks passed
@mergify mergify bot deleted the tomas/add-msrv branch February 25, 2025 11:30
mergify bot pushed a commit that referenced this pull request Feb 25, 2025
(cherry picked from commit f037759)
tzemanovic added a commit that referenced this pull request Feb 25, 2025
(cherry picked from commit f037759)
mergify bot added a commit that referenced this pull request Feb 25, 2025
define and check minimum supported Rust version in CI (backport #4398)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-libs-0.251 Backport libraries to 0.251 maintenance branch merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants