Skip to content

Fixed the speculative_context integration test for the hardware wallet.#4418

Merged
mergify[bot] merged 2 commits intomainfrom
murisi/fix-hw-speculative_context
Feb 26, 2025
Merged

Fixed the speculative_context integration test for the hardware wallet.#4418
mergify[bot] merged 2 commits intomainfrom
murisi/fix-hw-speculative_context

Conversation

@murisi
Copy link
Copy Markdown
Collaborator

@murisi murisi commented Feb 26, 2025

Describe your changes

Fixed the speculative_context integration test for the hardware wallet by ensuring that the --use-device flag is applied to its commands when the environment variable NAMADA_E2E_USE_DEVICE=true.

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

@murisi murisi requested a review from tzemanovic February 26, 2025 11:44
@github-actions github-actions bot added the backport-libs-0.251 Backport libraries to 0.251 maintenance branch label Feb 26, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.54%. Comparing base (f037759) to head (4558855).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4418      +/-   ##
==========================================
+ Coverage   74.53%   74.54%   +0.01%     
==========================================
  Files         339      339              
  Lines      110504   110504              
==========================================
+ Hits        82359    82372      +13     
+ Misses      28145    28132      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tzemanovic tzemanovic added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Feb 26, 2025
@mergify mergify bot merged commit 75059e7 into main Feb 26, 2025
27 of 28 checks passed
@mergify mergify bot deleted the murisi/fix-hw-speculative_context branch February 26, 2025 14:09
mergify bot added a commit that referenced this pull request Feb 26, 2025
Fixed the `speculative_context` integration test for the hardware wallet. (backport #4418)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-libs-0.251 Backport libraries to 0.251 maintenance branch MASP merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants