Fixed the speculative_context integration test for the hardware wallet.#4418
Merged
mergify[bot] merged 2 commits intomainfrom Feb 26, 2025
Merged
Fixed the speculative_context integration test for the hardware wallet.#4418mergify[bot] merged 2 commits intomainfrom
speculative_context integration test for the hardware wallet.#4418mergify[bot] merged 2 commits intomainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4418 +/- ##
==========================================
+ Coverage 74.53% 74.54% +0.01%
==========================================
Files 339 339
Lines 110504 110504
==========================================
+ Hits 82359 82372 +13
+ Misses 28145 28132 -13 ☔ View full report in Codecov by Sentry. |
tzemanovic
approved these changes
Feb 26, 2025
Merged
3 tasks
mergify bot
added a commit
that referenced
this pull request
Feb 26, 2025
Fixed the `speculative_context` integration test for the hardware wallet. (backport #4418)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Fixed the
speculative_contextintegration test for the hardware wallet by ensuring that the--use-deviceflag is applied to its commands when the environment variableNAMADA_E2E_USE_DEVICE=true.Checklist before merging
breaking::labelsnamada-docsreponamada-indexerornamada-masp-indexer, a corresponding PR is opened in that repo