Skip to content

add consensus/protocol version#4524

Merged
tzemanovic merged 4 commits intomainfrom
tomas/add-protocol-version
Apr 2, 2025
Merged

add consensus/protocol version#4524
tzemanovic merged 4 commits intomainfrom
tomas/add-protocol-version

Conversation

@tzemanovic
Copy link
Copy Markdown
Collaborator

@tzemanovic tzemanovic commented Mar 31, 2025

Describe your changes

based on #4259

Added CONSENSUS_VERSION file in the root with the upcoming version 1. This is exposed in namada_core::consensus_version as well as returned in ABCI /abci_info response in the app_version field ("The application protocol version." in ABCI).

diff for review https://github.com/anoma/namada/pull/4524/files/a8325c5fe84dfab92b9b28fcf0549826cb357287..150247bc9a5905c2abda867a592cd68113ffbe6a

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

tzemanovic added a commit that referenced this pull request Mar 31, 2025
@github-actions github-actions bot added the breaking:api public API breaking change label Mar 31, 2025
@tzemanovic tzemanovic requested a review from sug0 April 1, 2025 15:05
@brentstone brentstone requested a review from grarco April 1, 2025 15:05
@tzemanovic tzemanovic added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Apr 1, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (a8325c5) to head (1073455).
Report is 29 commits behind head on main.

Additional details and impacted files
@@     Coverage Diff      @@
##   main   #4524   +/-   ##
============================
============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tzemanovic tzemanovic force-pushed the tomas/add-protocol-version branch from 150247b to 1073455 Compare April 2, 2025 07:25
mergify bot added a commit that referenced this pull request Apr 2, 2025
let mut consensus_version_rs =
File::create(PathBuf::from_iter([&out_dir, "consensus_version.rs"]))
.expect("cannot write consensus version");
let pre = "/// Get the current consensus version\npub fn \
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you want you can use a doc attribute, which avoids the extra whitespace,

#[doc = "Get the current consensus version"]

mergify bot added a commit that referenced this pull request Apr 2, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 2, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 2, 2025

Hey @tzemanovic, your pull request has been dequeued due to the following reason: CHECKS_FAILED.
Sorry about that, but you can requeue the PR by using @mergifyio requeue if you think this was a mistake.

@tzemanovic tzemanovic merged commit baf0ba8 into main Apr 2, 2025
23 of 26 checks passed
@tzemanovic tzemanovic deleted the tomas/add-protocol-version branch April 2, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking:api public API breaking change merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants