Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4524 +/- ##
============================
============================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
150247b to
1073455
Compare
| let mut consensus_version_rs = | ||
| File::create(PathBuf::from_iter([&out_dir, "consensus_version.rs"])) | ||
| .expect("cannot write consensus version"); | ||
| let pre = "/// Get the current consensus version\npub fn \ |
There was a problem hiding this comment.
if you want you can use a doc attribute, which avoids the extra whitespace,
#[doc = "Get the current consensus version"]|
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks: You may have to fix your CI before adding the pull request to the queue again. |
|
Hey @tzemanovic, your pull request has been dequeued due to the following reason: CHECKS_FAILED. |
Describe your changes
based on #4259
Added
CONSENSUS_VERSIONfile in the root with the upcoming version 1. This is exposed innamada_core::consensus_versionas well as returned in ABCI/abci_inforesponse in theapp_versionfield ("The application protocol version." in ABCI).diff for review https://github.com/anoma/namada/pull/4524/files/a8325c5fe84dfab92b9b28fcf0549826cb357287..150247bc9a5905c2abda867a592cd68113ffbe6a
Checklist before merging
breaking::labelsnamada-docsreponamada-indexerornamada-masp-indexer, a corresponding PR is opened in that repo