Skip to content

Implemented logic to update transaction WASMs in hard-fork migration.#4540

Merged
mergify[bot] merged 2 commits intomainfrom
murisi/migrate-wasms
May 6, 2025
Merged

Implemented logic to update transaction WASMs in hard-fork migration.#4540
mergify[bot] merged 2 commits intomainfrom
murisi/migrate-wasms

Conversation

@murisi
Copy link
Copy Markdown
Collaborator

@murisi murisi commented Apr 3, 2025

Describe your changes

Implemented hard-fork migration code to update WASM code storage.

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

@github-actions github-actions bot added the backport-libs-0.150 Backport to libraries 0.150 maintenance branch label Apr 3, 2025
@murisi murisi force-pushed the murisi/migrate-wasms branch 2 times, most recently from c4dbdba to ebdf122 Compare April 3, 2025 17:24
@murisi murisi force-pushed the murisi/migrate-wasms branch from ebdf122 to ad7db27 Compare April 7, 2025 13:20
@sug0 sug0 self-requested a review April 7, 2025 13:38
Copy link
Copy Markdown
Collaborator

@batconjurer batconjurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks fine. Are we planning on using this example file to make the migration json?

@murisi
Copy link
Copy Markdown
Collaborator Author

murisi commented Apr 7, 2025

The code looks fine. Are we planning on using this example file to make the migration json?

Thanks. Yes, in accordance with the instructions at: https://hackmd.io/oqLHjyvwRMaxSD5JJNrB2w?both#Combined-migration-instructions .

@murisi murisi mentioned this pull request Apr 7, 2025
3 tasks
@tzemanovic tzemanovic added backport-libs-0.251 Backport libraries to 0.251 maintenance branch and removed backport-libs-0.150 Backport to libraries 0.150 maintenance branch labels May 6, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented May 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (6fee826) to head (ad7db27).
Report is 69 commits behind head on main.

Additional details and impacted files
@@     Coverage Diff      @@
##   main   #4540   +/-   ##
============================
============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tzemanovic tzemanovic added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label May 6, 2025
mergify bot added a commit that referenced this pull request May 6, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented May 6, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented May 6, 2025

Hey @murisi, your pull request has been dequeued due to the following reason: CHECKS_FAILED.
Sorry about that, but you can requeue the PR by using @mergifyio requeue if you think this was a mistake.

@tzemanovic
Copy link
Copy Markdown
Collaborator

@Mergifyio requeue

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented May 6, 2025

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

mergify bot added a commit that referenced this pull request May 6, 2025
@mergify mergify bot merged commit 59da0eb into main May 6, 2025
28 checks passed
@mergify mergify bot deleted the murisi/migrate-wasms branch May 6, 2025 16:15
mergify bot added a commit that referenced this pull request May 7, 2025
Implemented logic to update transaction WASMs in hard-fork migration. (backport #4540)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-libs-0.251 Backport libraries to 0.251 maintenance branch merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants