Skip to content

Murisi/set masp params migration#4589

Merged
mergify[bot] merged 4 commits intomainfrom
murisi/set-masp-params-migration
May 9, 2025
Merged

Murisi/set masp params migration#4589
mergify[bot] merged 4 commits intomainfrom
murisi/set-masp-params-migration

Conversation

@murisi
Copy link
Copy Markdown
Collaborator

@murisi murisi commented Apr 18, 2025

Describe your changes

Implemented a hard-fork migration that allows shielded reward parameters to be set. This is useful when testing shielded rewards on mainnet clones.

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

@murisi murisi added MASP breaking:consensus Consensus breaking change that requires a hard-fork labels Apr 18, 2025
@github-actions github-actions bot added the breaking:api public API breaking change label Apr 18, 2025
@murisi murisi force-pushed the murisi/set-masp-params-migration branch from 95c7607 to 720e1ac Compare May 7, 2025 13:47
@murisi murisi force-pushed the murisi/set-masp-params-migration branch from 720e1ac to aaa0287 Compare May 7, 2025 14:06
@murisi murisi removed the breaking:consensus Consensus breaking change that requires a hard-fork label May 7, 2025
@murisi murisi mentioned this pull request May 7, 2025
3 tasks
Copy link
Copy Markdown
Collaborator

@grarco grarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments but looks good to me

@murisi murisi force-pushed the murisi/set-masp-params-migration branch from aaa0287 to a68fc5d Compare May 9, 2025 13:15
@github-actions github-actions bot added the backport-libs-0.251 Backport libraries to 0.251 maintenance branch label May 9, 2025
@tzemanovic tzemanovic removed the breaking:api public API breaking change label May 9, 2025
@tzemanovic tzemanovic added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label May 9, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented May 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (c2cddf3) to head (a68fc5d).
Report is 20 commits behind head on main.

Additional details and impacted files
@@     Coverage Diff      @@
##   main   #4589   +/-   ##
============================
============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

mergify bot added a commit that referenced this pull request May 9, 2025
@mergify mergify bot merged commit d03e957 into main May 9, 2025
28 checks passed
@mergify mergify bot deleted the murisi/set-masp-params-migration branch May 9, 2025 15:26
mergify bot added a commit that referenced this pull request Jun 2, 2025
@mergify mergify bot mentioned this pull request Jun 4, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-libs-0.251 Backport libraries to 0.251 maintenance branch MASP merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants