Merged
Conversation
95c7607 to
720e1ac
Compare
720e1ac to
aaa0287
Compare
grarco
reviewed
May 7, 2025
grarco
reviewed
May 7, 2025
grarco
reviewed
May 7, 2025
grarco
approved these changes
May 7, 2025
Collaborator
grarco
left a comment
There was a problem hiding this comment.
Minor comments but looks good to me
aaa0287 to
a68fc5d
Compare
tzemanovic
approved these changes
May 9, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4589 +/- ##
============================
============================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3 tasks
mergify bot
added a commit
that referenced
this pull request
Jun 2, 2025
Murisi/set masp params migration (backport #4589)
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Implemented a hard-fork migration that allows shielded reward parameters to be set. This is useful when testing shielded rewards on mainnet clones.
Checklist before merging
breaking::labelsnamada-docsreponamada-indexerornamada-masp-indexer, a corresponding PR is opened in that repo