pgf/governance disallow non-native transfers

[Fraccaman]

Describe your changes

Checklist before merging

• If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
  • This will require 2 reviewers to approve the changes
• If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
  • Relevant PR if applies:
• If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
  • Relevant PR if applies:

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (29ccb55) to head (0cd4c35).
Report is 26 commits behind head on main.

Additional details and impacted files

@@     Coverage Diff      @@
##   main   #4667   +/-   ##
============================
============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Fraccaman]

@cwgoes we should always allow credit to pgf and governance addresses right?

[brentstone]

@cwgoes we should always allow credit to pgf and governance addresses right?

Anyone should always be allowed to send tokens TO these addresses, yes. @Fraccaman

[grarco]

I think I've missed this in my first review, this can be new_const too

[sug0]

I think the code might be fine now, but if possible here are some tests that would be nice to have:

1. making sure the pgf/gov balance can decrease/increase with governance proposals (with native or non-native tokens)
2. making sure the pgf/gov balance can increase (with native or non-native tokens)
3. making sure the pgf/gov balance cannot decrease (with native or non-native tokens)

only a subset of these tests is implemented. it should be relatively easy to impl them, should be a copy/paste of some test and changing a few things

[brentstone]

@sug0 let's leave the remaining tests for another PR. We need to merge this and cut a release ASAP to at least start testing on Housefire

[Fraccaman]

making sure the pgf/gov balance can decrease/increase with governance proposals (with native or non-native tokens)

We have an e2e test that does this with IBC

making sure the pgf/gov balance can increase (with native or non-native tokens)

I think i've added test_pgf_non_native_credit and test_governance_non_native_credit to check if balance can increase with non-native tokens

making sure the pgf/gov balance cannot decrease

Same here with test_governance_non_native_debit and test_pgf_non_native_debit

Native token credit is also tested by e2e test and unit test where we check that a proposal was initialized correctly (the proposal author has to deposit some nam). Maybe I can add a test for native token debit.

Will impl remaining tests later. Need merged now